Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1013443002: [Telemetry] Add repeatable flag to DragAction interaction record (Closed)

Created:
5 years, 9 months ago by nednguyen
Modified:
5 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add repeatable flag to DragAction interaction record BUG=466196 TEST=/tools/perf/run_benchmark --browser system gpu_times.gpu_rasterization.top_25_smooth --reset-results --page-filter=Maps Committed: https://crrev.com/6b4fb8c256709b144fef78bb12af033e9c8e615f Cr-Commit-Position: refs/heads/master@{#320757}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf/page_sets/top_25_smooth.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
nednguyen
5 years, 9 months ago (2015-03-14 17:03:39 UTC) #3
David Yen
On 2015/03/14 17:03:39, nednguyen wrote: Looks like this fixed the exception, lgtm!
5 years, 9 months ago (2015-03-16 17:23:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013443002/20001
5 years, 9 months ago (2015-03-16 17:27:52 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-16 17:27:54 UTC) #8
aiolos (Not reviewing)
On 2015/03/16 17:27:54, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 9 months ago (2015-03-16 17:29:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013443002/20001
5 years, 9 months ago (2015-03-16 17:29:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-16 18:33:32 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 18:34:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b4fb8c256709b144fef78bb12af033e9c8e615f
Cr-Commit-Position: refs/heads/master@{#320757}

Powered by Google App Engine
This is Rietveld 408576698