Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1013413003: html_viewer: Set expected content length to -1 in ToWebURLResponse(). (Closed)

Created:
5 years, 9 months ago by xhwang
Modified:
5 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

html_viewer: Set expected content length to -1 in ToWebURLResponse(). Currently ToWebURLResponse() is not setting the expected content length. The default value from Blink is 0. In Chromium, -1 means "Not available". This CL sets this value to -1 to be consistent with the Chromium net/ code. See content/public/common/resource_response_info.h. BUG=468489 TEST=html_viewer works with streaming servers. Committed: https://crrev.com/bc1ee8a26a899b13bd19ca2c6e486d37610fc380 Cr-Commit-Position: refs/heads/master@{#321600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M mojo/services/html_viewer/weburlloader_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
xhwang
rvargas / mpcomplete: This might be a hack, but it works for us. Please take ...
5 years, 9 months ago (2015-03-19 18:03:51 UTC) #2
rvargas (doing something else)
The change looks fine to me but I'm not the right person to say if ...
5 years, 9 months ago (2015-03-19 19:07:10 UTC) #3
jamesr
lgtm
5 years, 9 months ago (2015-03-19 19:50:19 UTC) #4
xhwang
mpcomplete: kindly ping?
5 years, 9 months ago (2015-03-20 01:00:07 UTC) #5
Matt Perry
lgtm
5 years, 9 months ago (2015-03-20 17:49:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013413003/1
5 years, 9 months ago (2015-03-20 17:50:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 18:12:30 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 18:13:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc1ee8a26a899b13bd19ca2c6e486d37610fc380
Cr-Commit-Position: refs/heads/master@{#321600}

Powered by Google App Engine
This is Rietveld 408576698