[bindings] Refactor ScriptStateForTesting, V8TestingScope into V8BindingForTesting.h/cpp

Source/bindings/core/v8/V8BindingForTesting.cpp

Index: Source/bindings/core/v8/V8BindingForTesting.cpp
diff --git a/Source/bindings/core/v8/V8TestingScope.cpp b/Source/bindings/core/v8/V8BindingForTesting.cpp
similarity index 50%
rename from Source/bindings/core/v8/V8TestingScope.cpp
rename to Source/bindings/core/v8/V8BindingForTesting.cpp
index 3cb08ed8e7a57d89fcf043f4dd9c3effbba18db3..15831d785cf1536cd66abd0065e9dffed1a12b7c 100644
--- a/Source/bindings/core/v8/V8TestingScope.cpp
+++ b/Source/bindings/core/v8/V8BindingForTesting.cpp
@@ -3,12 +3,36 @@
 // found in the LICENSE file.
 
 #include "config.h"
-#include "bindings/core/v8/V8TestingScope.h"
+#include "bindings/core/v8/V8BindingForTesting.h"
 
 #include "bindings/core/v8/DOMWrapperWorld.h"
 
 namespace blink {
 
+PassRefPtr<ScriptStateForTesting> ScriptStateForTesting::create(v8::Handle<v8::Context> context, PassRefPtr<DOMWrapperWorld> world)
+{
+    RefPtr<ScriptStateForTesting> scriptState = adoptRef(new ScriptStateForTesting(context, world));
+    // This ref() is for keeping this ScriptState alive as long as the v8::Context is alive.
+    // This is deref()ed in the weak callback of the v8::Context.

[Nico, 2015/08/29 21:42:48]

This seems to not work, see
http://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan%20tester/...
:

Direct leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0x58e708 in __interceptor_malloc
/b/build/slave/ClangToTLinuxASan/build/src/third_party/llvm/compiler-rt/lib/asan/asan_malloc_linux.cc:40
    #1 0x1d8f580 in partitionAllocGenericFlags
third_party/WebKit/Source/wtf/PartitionAlloc.h:691:20
    #2 0x1d8f580 in partitionAllocGeneric
third_party/WebKit/Source/wtf/PartitionAlloc.h:707
    #3 0x1d8f580 in WTF::fastMalloc(unsigned long)
third_party/WebKit/Source/wtf/FastMalloc.cpp:56
    #4 0x648bf4 in operator new third_party/WebKit/Source/wtf/RefCounted.h:166:5
    #5 0x648bf4 in blink::ScriptStateForTesting::create(v8::Local<v8::Context>,
WTF::PassRefPtr<blink::DOMWrapperWorld>)
third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp:14
    #6 0x5b58a1 in (anonymous
namespace)::ScriptPromisePropertyTestBase::ScriptPromisePropertyTestBase()
third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp:129:30
    #7 0x5d433b in (anonymous
namespace)::ScriptPromisePropertyRefCountedTest::ScriptPromisePropertyRefCountedTest()
third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp:433:5
    #8 0x5d424a in ScriptPromisePropertyRefCountedTest_Resolve_Test
third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp:445:1


Can you take a look?

[haraken, 2015/08/30 01:26:07]

I think this is an issue of ScriptPromisePropertyTest.

yhirano@?

+    scriptState->ref();
+    return scriptState;
+}
+
+ScriptStateForTesting::ScriptStateForTesting(v8::Handle<v8::Context> context, PassRefPtr<DOMWrapperWorld> world)
+    : ScriptState(context, world)
+{
+}
+
+ExecutionContext* ScriptStateForTesting::executionContext() const
+{
+    return m_executionContext;
+}
+
+void ScriptStateForTesting::setExecutionContext(ExecutionContext* executionContext)
+{
+    m_executionContext = executionContext;
+}
+
 V8TestingScope::V8TestingScope(v8::Isolate* isolate)
     : m_handleScope(isolate)
     , m_contextScope(v8::Context::New(isolate))