Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: Source/core/html/track/CueTimeline.cpp

Issue 1013393004: Eliminate TextTrackCue::updateDisplayTree() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: coerce m_isPastNode to bool Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/StyleChangeReason.cpp ('k') | Source/core/html/track/TextTrackContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/CueTimeline.cpp
diff --git a/Source/core/html/track/CueTimeline.cpp b/Source/core/html/track/CueTimeline.cpp
index 6c1d7e3dd6f19c1aa9b8af95f042d9e559bd24e6..796dd6e83ffb625b85e9cbcff0493f9fa4b954f9 100644
--- a/Source/core/html/track/CueTimeline.cpp
+++ b/Source/core/html/track/CueTimeline.cpp
@@ -206,9 +206,13 @@ void CueTimeline::updateActiveCues(double movieTime)
}
for (CueInterval currentCue : currentCues) {
- currentCue.data()->updateDisplayTree(movieTime);
-
- if (!currentCue.data()->isActive())
+ // Notify any cues that are already active of the current time to mark
+ // past and future nodes. Any inactive cues have an empty display state;
+ // they will be notified of the current time when the display state is
+ // updated.
+ if (currentCue.data()->isActive())
+ currentCue.data()->updatePastAndFutureNodes(movieTime);
+ else
activeSetChanged = true;
}
« no previous file with comments | « Source/core/dom/StyleChangeReason.cpp ('k') | Source/core/html/track/TextTrackContainer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698