Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1013373002: base: Remove DiscardableMemory::CreateLockedMemory. (Closed)

Created:
5 years, 9 months ago by reveman
Modified:
5 years, 9 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, gavinp+memory_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Remove DiscardableMemory::CreateLockedMemory. Use DiscardableMemoryAllocator interface directly instead. This also updates the comments for the DiscardableMemory class to reflect the current state of discardable memory. BUG=422953 Committed: https://crrev.com/e7b4233be5698604ef4466d2f76dfd84bfb96542 Cr-Commit-Position: refs/heads/master@{#321076}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix win build issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -36 lines) Patch
M base/memory/discardable_memory.h View 1 2 2 chunks +12 lines, -23 lines 0 comments Download
D base/memory/discardable_memory.cc View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
M content/child/web_discardable_memory_impl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/child/web_discardable_memory_impl.cc View 2 chunks +5 lines, -1 line 0 comments Download
M skia/ext/SkDiscardableMemory_chrome.h View 1 chunk +4 lines, -1 line 0 comments Download
M skia/ext/SkDiscardableMemory_chrome.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
reveman
5 years, 9 months ago (2015-03-18 01:10:50 UTC) #2
Nico
lgtm
5 years, 9 months ago (2015-03-18 01:14:09 UTC) #3
Avi (use Gerrit)
lgtm
5 years, 9 months ago (2015-03-18 02:18:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013373002/40001
5 years, 9 months ago (2015-03-18 02:40:52 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-18 04:40:25 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 04:41:31 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e7b4233be5698604ef4466d2f76dfd84bfb96542
Cr-Commit-Position: refs/heads/master@{#321076}

Powered by Google App Engine
This is Rietveld 408576698