Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1013363002: locating runtime files automatically (fixes #96) (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -20 lines) Patch
M lib/devc.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M lib/src/dependency_graph.dart View 5 chunks +36 lines, -13 lines 0 comments Download
M lib/src/options.dart View 1 7 chunks +67 lines, -2 lines 0 comments Download
M lib/src/testing.dart View 3 chunks +8 lines, -0 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +17 lines, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M test/codegen_test.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M test/dependency_graph_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
FYI - I ran into issues in `pub global activate` because of https://code.google.com/p/dart/issues/detail?id=22864 I tested ...
5 years, 9 months ago (2015-03-17 23:23:05 UTC) #3
vsm
lgtm
5 years, 9 months ago (2015-03-18 01:50:45 UTC) #4
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-18 01:52:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
02bea238e40c92911a8b33e09998cbcab50a8acd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698