Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1013323002: Add an icon for SkyDemo (required by the play store) (Closed)

Created:
5 years, 9 months ago by eseidel
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@sky_sdk
Target Ref:
refs/heads/sky_sdk
Project:
mojo
Visibility:
Public.

Description

Add an icon for SkyDemo (required by the play store) This doesn't actually wire the icon into the apk building. I will do that in a separate step from my linux machine. It will require a couple lines edit in BUILD.gn R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d782adeb185a93c3b11168d358342b243bf87f3e Committed: https://chromium.googlesource.com/external/mojo/+/900898ad93d380ff7440888857566cb68cf65927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M sky/apk/demo/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
A sky/apk/demo/README.md View 1 chunk +6 lines, -0 lines 0 comments Download
A sky/apk/demo/res/mipmap-hdpi/ic_launcher.png View Binary file 0 comments Download
A sky/apk/demo/res/mipmap-mdpi/ic_launcher.png View Binary file 0 comments Download
A sky/apk/demo/res/mipmap-xhdpi/ic_launcher.png View Binary file 0 comments Download
A sky/apk/demo/res/mipmap-xxhdpi/ic_launcher.png View Binary file 0 comments Download
A sky/apk/demo/res/mipmap-xxxhdpi/ic_launcher.png View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
lgtm
5 years, 9 months ago (2015-03-17 21:41:17 UTC) #1
eseidel
Committed patchset #1 (id:1) manually as d782adeb185a93c3b11168d358342b243bf87f3e (presubmit successful).
5 years, 9 months ago (2015-03-17 21:43:13 UTC) #2
eseidel
5 years, 9 months ago (2015-03-17 21:56:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
900898ad93d380ff7440888857566cb68cf65927 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698