Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1013313002: Move services/files/*.mojom -> mojo/services/files/public/interfaces/. (Closed)

Created:
5 years, 9 months ago by viettrungluu
Modified:
5 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move services/files/*.mojom -> mojo/services/files/public/interfaces/. Ditto for terminal_client.mojom, previously in examples/echo_terminal. Fix the sky terminal example. R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c1240d7ce5819007bc42a7a6143f21030cb34957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -343 lines) Patch
M examples/echo_terminal/BUILD.gn View 1 chunk +1 line, -12 lines 0 comments Download
M examples/echo_terminal/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D examples/echo_terminal/terminal_client.mojom View 1 chunk +0 lines, -17 lines 0 comments Download
M mojo/services/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A + mojo/services/files/public/interfaces/BUILD.gn View 1 chunk +5 lines, -4 lines 0 comments Download
A + mojo/services/files/public/interfaces/directory.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/public/interfaces/file.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/interfaces/files.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/public/interfaces/types.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/terminal/public/interfaces/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download
A + mojo/services/terminal/public/interfaces/terminal_client.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M services/files/BUILD.gn View 3 chunks +2 lines, -12 lines 0 comments Download
D services/files/directory.mojom View 1 chunk +0 lines, -63 lines 0 comments Download
M services/files/directory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
D services/files/file.mojom View 1 chunk +0 lines, -85 lines 0 comments Download
M services/files/file_impl.h View 1 chunk +1 line, -1 line 0 comments Download
D services/files/files.mojom View 1 chunk +0 lines, -22 lines 0 comments Download
M services/files/files_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/files/files_test_base.h View 1 chunk +4 lines, -4 lines 0 comments Download
M services/files/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/files/shared_impl.h View 1 chunk +1 line, -1 line 0 comments Download
D services/files/types.mojom View 1 chunk +0 lines, -101 lines 0 comments Download
M services/files/util.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/terminal/terminal.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/terminal/terminal_file_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 9 months ago (2015-03-17 21:18:58 UTC) #1
Elliot Glaysher
lgtm
5 years, 9 months ago (2015-03-17 21:25:16 UTC) #2
viettrungluu
5 years, 9 months ago (2015-03-17 21:32:01 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c1240d7ce5819007bc42a7a6143f21030cb34957 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698