Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: Source/core/page/EventHandler.cpp

Issue 1013303003: Preventing the default action on 'mousemove' listener shouldn't prevent selection (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Modified the comment as per review comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/events/drag-on-mouse-move-cancelled-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/EventHandler.cpp
diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp
index 0e5258524a55d2ee8cfadc4ee43cb5c09d6bf6db..9cd235ba7b3fe077112e53a8210b28bf6498053c 100644
--- a/Source/core/page/EventHandler.cpp
+++ b/Source/core/page/EventHandler.cpp
@@ -1499,10 +1499,12 @@ bool EventHandler::handleMouseMoveOrLeaveEvent(const PlatformMouseEvent& mouseEv
return true;
swallowEvent = !dispatchMouseEvent(EventTypeNames::mousemove, mev.innerNode(), 0, mouseEvent, true);
- if (!swallowEvent)
- swallowEvent = handleMouseDraggedEvent(mev);
- return swallowEvent;
+ // http://www.w3.org/TR/DOM-Level-3-Events/#event-type-mousemove
+ // Since there is no default action for mousemove event as per spec,
+ // irrespective of whether event is cancelled or not there should not
leviw_travelin_and_unemployed 2015/03/30 17:27:51 How about "Since there is no default action for th
ramya.v 2015/03/31 04:52:13 Done.
+ // be any difference.
+ return handleMouseDraggedEvent(mev);
}
void EventHandler::invalidateClick()
« no previous file with comments | « LayoutTests/fast/events/drag-on-mouse-move-cancelled-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698