Issue 101323012: Revert of Stop recording CPU profiles when Profiler agent is disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101323012: Revert of Stop recording CPU profiles when Profiler agent is disabled (Closed)

Created:
7 years ago by yurys

Modified:
7 years ago

Reviewers:
alph, aandrey, qsr, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert of https://codereview.chromium.org/116273003/ Reason for revert: Broke compilation on Android TBR=alph@chromium.org,loislo@chromium.org,aandrey@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163963

Patch Set 1 #

Created: 7 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -108 lines)			Patch
D	LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html	View	1 chunk	+0 lines, -89 lines	0 comments	Download
D	LayoutTests/inspector-protocol/cpu-profiler/enable-disable-expected.txt	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	LayoutTests/inspector-protocol/cpu-profiler/record-cpu-profile.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorProfilerAgent.cpp	View	3 chunks	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

Created Revert of Stop recording CPU profiles when Profiler agent is disabled

7 years ago (2013-12-16 15:17:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/101323012/1

7 years ago (2013-12-16 15:17:27 UTC) #2

Message was sent while issue was closed.

Change committed as 163963

Expand Messages | Collapse Messages