Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 101323002: Stop setting invalid value to the |tab_id| field of fileBrowserHandler API. (Closed)

Created:
7 years ago by kinaba
Modified:
7 years ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Stop setting invalid value to the |tab_id| field of fileBrowserHandler API. Since the very long long ago when we have moved file manager out of tabs to a separate app window, it didn't have any tab_id associated, and the existing code always assigned an invalid value (-1). This CL removes the useless code. Since the field is defined to be optional, it doesn't change the interface of the API. BUG=312519 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238376

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
kinaba
ptal. It's a bit odd to have a field that'll never set, but since we ...
7 years ago (2013-12-03 08:07:06 UTC) #1
hirono
On 2013/12/03 08:07:06, kinaba wrote: > ptal. > > It's a bit odd to have ...
7 years ago (2013-12-03 08:30:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/101323002/1
7 years ago (2013-12-03 09:37:04 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-03 12:39:45 UTC) #4
Message was sent while issue was closed.
Change committed as 238376

Powered by Google App Engine
This is Rietveld 408576698