coverage: increase coverage of js_codegen

test/codegen_test.dart

Index: test/codegen_test.dart
diff --git a/test/codegen_test.dart b/test/codegen_test.dart
index dbe68ca7d783ff8a668fec14e9cc937f26f26ea1..fc5a60ac9c24c32d39ff9b328b8a1ed8c6ad4af8 100644
--- a/test/codegen_test.dart
+++ b/test/codegen_test.dart
@@ -57,13 +57,15 @@ main(arguments) {
       .where((p) => p.endsWith('.dart') && filePattern.hasMatch(p));
 
   compile(String entryPoint, String sdkPath,
-      {bool checkSdk: false, bool serverMode: false}) {
+      {bool checkSdk: false, bool serverMode: false, bool sourceMaps: false}) {
+    // TODO(jmesserly): add a way to specify flags in the test file, so
+    // they're more self-contained.
     var options = new CompilerOptions(
         outputDir: serverMode ? path.join(actualDir, 'server_mode') : actualDir,
         useColors: false,
         outputDart: dartGen,
         formatOutput: dartGen,
-        emitSourceMaps: false,
+        emitSourceMaps: sourceMaps,
         forceCompile: checkSdk,
         cheapTestFormat: checkSdk,
         checkSdk: checkSdk,
@@ -88,7 +90,10 @@ main(arguments) {
     test('devc $filename.dart', () {
       compilerMessages.writeln('// Messages from compiling $filename.dart');
 
-      var result = compile(filePath, realSdk);
+      // TODO(jmesserly): this was added to get some coverage of source maps
+      // We need a more comprehensive strategy to test them.

[Siggi Cherem (dart-lang), 2015/03/18 16:16:13]

how about detecting if there is one .map file in the expect folder?

sort of like how we detected if we needed a layout test in the past if there was
a .txt or a .png file with the name of the test next to it.

[Jennifer Messerly, 2015/03/18 16:17:53]

that's a really good idea. I also thought about having a way to specify options
in the test file, so you could pass --source-maps

+      var sourceMaps = filename == 'map_keys';
+      var result = compile(filePath, realSdk, sourceMaps: sourceMaps);
       var success = !result.failure;
 
       // Write compiler messages to disk.