coverage: increase coverage of js_codegen

coverage: increase coverage of js_codegen

it was already decent, but this should plug the two biggest holes: source maps and maps with non-string keys

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/94f6923c82c2fcfbeb57f40d8207de82cf8aa5b9

[Jennifer Messerly, 2015-03-18 16:09:01]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[vsm, 2015-03-18 16:11:37]

lgtm

[Siggi Cherem (dart-lang), 2015-03-18 16:16:12]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-03-18 16:16:13]

https://codereview.chromium.org/1013223002/diff/1/test/codegen_test.dart
File test/codegen_test.dart (right):

https://codereview.chromium.org/1013223002/diff/1/test/codegen_test.dart#newc...
test/codegen_test.dart:94: // We need a more comprehensive strategy to test
them.
how about detecting if there is one .map file in the expect folder?

sort of like how we detected if we needed a layout test in the past if there was
a .txt or a .png file with the name of the test next to it.

[Jennifer Messerly, 2015-03-18 16:17:53]

https://codereview.chromium.org/1013223002/diff/1/test/codegen_test.dart
File test/codegen_test.dart (right):

https://codereview.chromium.org/1013223002/diff/1/test/codegen_test.dart#newc...
test/codegen_test.dart:94: // We need a more comprehensive strategy to test
them.
On 2015/03/18 16:16:13, Siggi Cherem (dart-lang) wrote:
> how about detecting if there is one .map file in the expect folder?
> 
> sort of like how we detected if we needed a layout test in the past if there
was
> a .txt or a .png file with the name of the test next to it.

that's a really good idea. I also thought about having a way to specify options
in the test file, so you could pass --source-maps

[Jennifer Messerly, 2015-03-18 16:20:40]

Committed patchset #1 (id:1) manually as
94f6923c82c2fcfbeb57f40d8207de82cf8aa5b9 (presubmit successful).