Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1013183002: Stop mutating inputs to decomposeArcToCubic (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Stop mutating inputs to decomposeArcToCubic There's not a lot of gain from doing so, and not doing it will provide more freedom to the caller (w/ handling of current point.) BUG=467592 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/svg/SVGPathParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathParser.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 9 months ago (2015-03-17 15:33:41 UTC) #2
kouhei (in TOK)
lgtm clean up
5 years, 9 months ago (2015-03-17 15:45:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013183002/1
5 years, 9 months ago (2015-03-17 16:47:49 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 18:21:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192027

Powered by Google App Engine
This is Rietveld 408576698