Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: src/compiler.h

Issue 1013143003: CpuProfiler: push the collected information about deopts to cpu profiler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: leak was fixed Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | src/profile-generator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.h
diff --git a/src/compiler.h b/src/compiler.h
index e58562664732af04b5fb4fa589440ec30b5482bc..767e209449dd752299fdb8eee996be2c5fd5fa5c 100644
--- a/src/compiler.h
+++ b/src/compiler.h
@@ -97,7 +97,7 @@ struct InlinedFunctionInfo {
SourcePosition inline_position;
int script_id;
int start_position;
- std::vector<int> deopt_pc_offsets;
+ std::vector<size_t> deopt_pc_offsets;
alph 2015/03/20 08:28:42 Why's the change? AFAICT v8 tends to use 32-bit ty
static const int kNoParentId = -1;
};
@@ -347,7 +347,12 @@ class CompilationInfo {
}
int start_position_for(uint32_t inlining_id) {
- return inlined_function_infos_.at(inlining_id).start_position;
+ return inlined_function_infos_->at(inlining_id).start_position;
+ }
+ std::vector<InlinedFunctionInfo>* ReleaseInlinedFunctionInfos() {
+ std::vector<InlinedFunctionInfo>* tmp = inlined_function_infos_;
+ inlined_function_infos_ = NULL;
+ return tmp;
}
void LogDeoptCallPosition(int pc_offset, int inlining_id);
@@ -460,7 +465,7 @@ class CompilationInfo {
int prologue_offset_;
List<OffsetRange>* no_frame_ranges_;
- std::vector<InlinedFunctionInfo> inlined_function_infos_;
+ std::vector<InlinedFunctionInfo>* inlined_function_infos_;
alph 2015/03/20 08:28:42 why not using a smart pointer?
loislo 2015/03/20 08:53:11 done
bool track_positions_;
// A copy of shared_info()->opt_count() to avoid handle deref
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | src/profile-generator.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698