CpuProfiler: push the collected information about deopts to cpu profiler

src/compiler.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_H_
 #define V8_COMPILER_H_
 
 #include "src/allocation.h"
 #include "src/ast.h"
 #include "src/bailout-reason.h"
@@ skipping 79 matching lines @@
   InlinedFunctionInfo(int parent_id, SourcePosition inline_position,
                       int script_id, int start_position)
       : parent_id(parent_id),
         inline_position(inline_position),
         script_id(script_id),
         start_position(start_position) {}
   int parent_id;
   SourcePosition inline_position;
   int script_id;
   int start_position;
-  std::vector<int> deopt_pc_offsets;
+  std::vector<size_t> deopt_pc_offsets;
 
   static const int kNoParentId = -1;
 };
 
 
 // CompilationInfo encapsulates some information known at compile time.  It
 // is constructed based on the resources available at compile-time.
 class CompilationInfo {
  public:
   // Various configuration flags for a compilation, as well as some properties
@@ skipping 219 matching lines @@
 
   void set_prologue_offset(int prologue_offset) {
     DCHECK_EQ(Code::kPrologueOffsetNotSet, prologue_offset_);
     prologue_offset_ = prologue_offset;
   }
 
   // Adds offset range [from, to) where fp register does not point
   // to the current frame base. Used in CPU profiler to detect stack
   // samples where top frame is not set up.
   inline void AddNoFrameRange(int from, int to) {
-    if (no_frame_ranges_) no_frame_ranges_->Add(OffsetRange(from, to));
+    if (!no_frame_ranges_.is_empty())
+      no_frame_ranges_->Add(OffsetRange(from, to));
   }
 
   List<OffsetRange>* ReleaseNoFrameRanges() {
-    List<OffsetRange>* result = no_frame_ranges_;
-    no_frame_ranges_ = NULL;
-    return result;
+    return no_frame_ranges_.Detach();
   }
 
   int start_position_for(uint32_t inlining_id) {
-    return inlined_function_infos_.at(inlining_id).start_position;
+    return inlined_function_infos_->at(inlining_id).start_position;
+  }
+  std::vector<InlinedFunctionInfo>* ReleaseInlinedFunctionInfos() {
+    return inlined_function_infos_.Detach();

[Sven Panne, 2015/03/23 10:13:27]

This is horribly complicated: Can't we simply return the inlined_function_infos_
by value? How many entries are there typically in such a vector? AFAICT, there
should be only a handful.

The same holds for the Detach above, too.

   }
 
   void LogDeoptCallPosition(int pc_offset, int inlining_id);
   int TraceInlinedFunction(Handle<SharedFunctionInfo> shared,
                            SourcePosition position, int pareint_id);
 
   Handle<Foreign> object_wrapper() {
     if (object_wrapper_.is_null()) {
       object_wrapper_ =
           isolate()->factory()->NewForeign(reinterpret_cast<Address>(this));
@@ skipping 91 matching lines @@
   Zone* zone_;
 
   DeferredHandles* deferred_handles_;
 
   ZoneList<Handle<HeapObject> >* dependencies_[DependentCode::kGroupCount];
 
   BailoutReason bailout_reason_;
 
   int prologue_offset_;
 
-  List<OffsetRange>* no_frame_ranges_;
-  std::vector<InlinedFunctionInfo> inlined_function_infos_;
+  SmartPointer<List<OffsetRange>> no_frame_ranges_;
+  SmartPointer<std::vector<InlinedFunctionInfo>> inlined_function_infos_;

[Sven Panne, 2015/03/23 10:13:26]

Following the KISS principle, leave the instance fields just like they were
without any explicit dynamic allocation/SmartPointers/etc.  Don't nano-optimize
the CompilationInfo memory consumption when we burn tons of MBs later in the
compilation pipelines, anyway.

   bool track_positions_;
 
   // A copy of shared_info()->opt_count() to avoid handle deref
   // during graph optimization.
   int opt_count_;
 
   // Number of parameters used for compilation of stubs that require arguments.
   int parameter_count_;
 
   Handle<Foreign> object_wrapper_;
@@ skipping 227 matching lines @@
   Zone zone_;
   size_t info_zone_start_allocation_size_;
   base::ElapsedTimer timer_;
 
   DISALLOW_COPY_AND_ASSIGN(CompilationPhase);
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_COMPILER_H_