CpuProfiler: push the collected information about deopts to cpu profiler

src/profile-generator.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/profile-generator-inl.h"
 
 #include "src/compiler.h"
 #include "src/debug.h"
@@ skipping 34 matching lines @@
 
 const char* const CodeEntry::kEmptyNamePrefix = "";
 const char* const CodeEntry::kEmptyResourceName = "";
 const char* const CodeEntry::kEmptyBailoutReason = "";
 const char* const CodeEntry::kNoDeoptReason = "";
 
 
 CodeEntry::~CodeEntry() {
   delete no_frame_ranges_;
   delete line_info_;
+  delete inlined_function_infos_;
 }
 
 
 uint32_t CodeEntry::GetHash() const {
   uint32_t hash = ComputeIntegerHash(tag(), v8::internal::kZeroHashSeed);
   if (script_id_ != v8::UnboundScript::kNoScriptId) {
     hash ^= ComputeIntegerHash(static_cast<uint32_t>(script_id_),
                                v8::internal::kZeroHashSeed);
     hash ^= ComputeIntegerHash(static_cast<uint32_t>(position_),
                                v8::internal::kZeroHashSeed);
@@ skipping 40 matching lines @@
 
 void CodeEntry::FillFunctionInfo(SharedFunctionInfo* shared) {
   if (!shared->script()->IsScript()) return;
   Script* script = Script::cast(shared->script());
   set_script_id(script->id()->value());
   set_position(shared->start_position());
   set_bailout_reason(GetBailoutReason(shared->disable_optimization_reason()));
 }
 
 
+DeoptInfo* CodeEntry::GetDeoptInfo() {
+  DCHECK(has_deopt_info());
+  DCHECK(inlined_function_infos_);
+
+  DeoptInfo* info = new DeoptInfo;
+  info->deopt_reason = deopt_reason_;
+  if (inlined_function_infos_->empty()) {
+    info->stack.push_back(DeoptInfo::Frame(
+        {script_id_,
+         static_cast<int>(position_ + deopt_position_.position())}));
+    return info;
+  }
+  // Copy the only branch from the inlining tree where the deopt happened.
+  SourcePosition position = deopt_position_;
+  int inlining_id = InlinedFunctionInfo::kNoParentId;
+  for (size_t i = 0; i < inlined_function_infos_->size(); ++i) {
+    InlinedFunctionInfo& current_info = inlined_function_infos_->at(i);
+    if (std::binary_search(current_info.deopt_pc_offsets.begin(),
+                           current_info.deopt_pc_offsets.end(), pc_offset_)) {
+      inlining_id = static_cast<int>(i);
+      break;
+    }
+  }
+  while (inlining_id != InlinedFunctionInfo::kNoParentId) {
+    InlinedFunctionInfo& inlined_info =
+        inlined_function_infos_->at(inlining_id);
+    info->stack.push_back(DeoptInfo::Frame(
+        {inlined_info.script_id,
+         static_cast<int>(inlined_info.start_position + position.raw())}));
+    position = inlined_info.inline_position;
+    inlining_id = inlined_info.parent_id;
+  }
+  return info;
+}
+
+
+ProfileNode::~ProfileNode() {
+  for (auto deopt_info : deopt_infos_) delete deopt_info;
+}
+
+
 void ProfileNode::CollectDeoptInfo(CodeEntry* entry) {
-  deopt_infos_.Add(DeoptInfo(entry->deopt_reason(), entry->deopt_position()));
+  deopt_infos_.push_back(entry->GetDeoptInfo());
   entry->clear_deopt_info();
 }
 
 
 ProfileNode* ProfileNode::FindChild(CodeEntry* entry) {
   HashMap::Entry* map_entry =
       children_.Lookup(entry, CodeEntryHash(entry), false);
   return map_entry != NULL ?
       reinterpret_cast<ProfileNode*>(map_entry->value) : NULL;
 }
@@ skipping 47 matching lines @@
 }
 
 
 void ProfileNode::Print(int indent) {
   base::OS::Print("%5u %*s %s%s %d #%d", self_ticks_, indent, "",
                   entry_->name_prefix(), entry_->name(), entry_->script_id(),
                   id());
   if (entry_->resource_name()[0] != '\0')
     base::OS::Print(" %s:%d", entry_->resource_name(), entry_->line_number());
   base::OS::Print("\n");
-  for (auto info : deopt_infos_) {
-    if (FLAG_hydrogen_track_positions) {
-      base::OS::Print("%*s deopted at %d_%d with reason '%s'\n", indent + 10,
-                      "", info.deopt_position.inlining_id(),
-                      info.deopt_position.position(), info.deopt_reason);
-    } else {
-      base::OS::Print("%*s deopted at %d with reason '%s'\n", indent + 10, "",
-                      info.deopt_position.raw(), info.deopt_reason);
+  for (size_t i = 0; i < deopt_infos_.size(); ++i) {
+    DeoptInfo* info = deopt_infos_[i];
+    base::OS::Print(
+        "%*s;;; deopted at script_id: %d position: %d with reason '%s'.\n",
+        indent + 10, "", info->stack[0].script_id, info->stack[0].position,
+        info->deopt_reason);
+    for (size_t i = 1; i < info->stack.size(); ++i) {

[alph, 2015/03/20 08:28:42]

could you please use a distinct variable for inner loop iterator.

[loislo, 2015/03/20 08:53:11]

done

+      base::OS::Print("%*s;;;     Inline point: script_id %d position: %d.\n",
+                      indent + 10, "", info->stack[i].script_id,
+                      info->stack[i].position);
     }
   }
   const char* bailout_reason = entry_->bailout_reason();
   if (bailout_reason != GetBailoutReason(BailoutReason::kNoReason) &&
       bailout_reason != CodeEntry::kEmptyBailoutReason) {
     base::OS::Print("%*s bailed out due to '%s'\n", indent + 10, "",
                     bailout_reason);
   }
   for (HashMap::Entry* p = children_.Start();
        p != NULL;
@@ skipping 454 matching lines @@
     case OTHER:
     case EXTERNAL:
       return program_entry_;
     case IDLE:
       return idle_entry_;
     default: return NULL;
   }
 }
 
 } }  // namespace v8::internal