Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 101303005: .isolated version 1.2 uses 'path_variables' instead of 'variables'. (Closed)

Created:
7 years ago by M-A Ruel
Modified:
7 years ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org, csharp, Nico, Vadim Sh.
Base URL:
https://chromium.googlesource.com/a/chromium/tools/build.git@master
Visibility:
Public.

Description

.isolated version 1.2 uses 'path_variables' instead of 'variables'. Fix runisolatedtest.py hack to support both. Add note about the life expectancy of this script. R=stip@chromium.org BUG=311622 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=240727

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M scripts/slave/runisolatedtest.py View 3 chunks +14 lines, -5 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
The .isolated format upgraded broke the expectations in runisolatedtest.py. It is annoying because this script ...
7 years ago (2013-12-13 19:47:27 UTC) #1
ghost stip (do not use)
lgtm
7 years ago (2013-12-13 19:59:53 UTC) #2
Nico
lgtm https://codereview.chromium.org/101303005/diff/1/scripts/slave/runisolatedtest.py File scripts/slave/runisolatedtest.py (right): https://codereview.chromium.org/101303005/diff/1/scripts/slave/runisolatedtest.py#newcode115 scripts/slave/runisolatedtest.py:115: if isolated_data['version'].split('.', 1)[0] != '1': Should this be ...
7 years ago (2013-12-13 20:00:06 UTC) #3
M-A Ruel
https://codereview.chromium.org/101303005/diff/1/scripts/slave/runisolatedtest.py File scripts/slave/runisolatedtest.py (right): https://codereview.chromium.org/101303005/diff/1/scripts/slave/runisolatedtest.py#newcode115 scripts/slave/runisolatedtest.py:115: if isolated_data['version'].split('.', 1)[0] != '1': On 2013/12/13 20:00:06, Nico ...
7 years ago (2013-12-13 20:02:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/101303005/1
7 years ago (2013-12-13 20:13:24 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-13 20:14:28 UTC) #6
Message was sent while issue was closed.
Change committed as 240727

Powered by Google App Engine
This is Rietveld 408576698