Add tests for Component Updater command line arguments

chrome/browser/component_updater/test/chrome_component_updater_configurator_unittest.cc

Index: chrome/browser/component_updater/test/chrome_component_updater_configurator_unittest.cc
diff --git a/chrome/browser/component_updater/test/chrome_component_updater_configurator_unittest.cc b/chrome/browser/component_updater/test/chrome_component_updater_configurator_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1e2689d5b6b4e68e0dbb2a36c0bb0752905e068f
--- /dev/null
+++ b/chrome/browser/component_updater/test/chrome_component_updater_configurator_unittest.cc
@@ -0,0 +1,63 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/command_line.h"
+#include "chrome/browser/component_updater/chrome_component_updater_configurator.h"
+#include "components/component_updater/component_updater_switches.h"
+#include "components/update_client/configurator.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
+
+namespace component_updater {
+
+TEST(ChromeComponentUpdaterConfiguratorTest, TestDisablePings) {
+  base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();
+  cmdline->AppendSwitchASCII(switches::kComponentUpdater, "disable-pings");
+
+  const update_client::Configurator* config =

[Sorin Jianu, 2015/03/25 20:32:21]

I missed the memory leak here and below.

I am working on code right now where I made the Configurator a ref_counted type,
specifically to avoid similar issues.

+      MakeChromeComponentUpdaterConfigurator(cmdline, NULL);
+
+  const std::vector<GURL> pingUrls = config->PingUrl();
+  EXPECT_TRUE(pingUrls.empty());
+}
+
+TEST(ChromeComponentUpdaterConfiguratorTest, TestFastUpdate) {
+  base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();
+  cmdline->AppendSwitchASCII(switches::kComponentUpdater, "fast-update");
+
+  const update_client::Configurator* config =
+      MakeChromeComponentUpdaterConfigurator(cmdline, NULL);
+
+  ASSERT_EQ(1, config->InitialDelay());
+}
+
+TEST(ChromeComponentUpdaterConfiguratorTest, TestOverrideUrl) {
+  const char overrideUrl[] = "http://0.0.0.0/";
+
+  base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();
+  std::string val = "url-source";
+  val.append("=");
+  val.append(overrideUrl);
+  cmdline->AppendSwitchASCII(switches::kComponentUpdater, val.c_str());
+
+  const update_client::Configurator* config =
+      MakeChromeComponentUpdaterConfigurator(cmdline, NULL);
+
+  const std::vector<GURL> urls = config->UpdateUrl();
+
+  ASSERT_EQ(1U, urls.size());
+  ASSERT_EQ(overrideUrl, urls.at(0).possibly_invalid_spec());
+}
+
+TEST(ChromeComponentUpdaterConfiguratorTest, TestSwitchRequestParam) {
+  base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();
+  cmdline->AppendSwitchASCII(switches::kComponentUpdater, "test-request");
+
+  const update_client::Configurator* config =
+      MakeChromeComponentUpdaterConfigurator(cmdline, NULL);
+
+  EXPECT_FALSE(config->ExtraRequestParams().empty());
+}
+
+}  // namespace component_updater