Add tests for Component Updater command line arguments

chrome/browser/component_updater/test/chrome_component_updater_configurator_unittest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/command_line.h"
+#include "chrome/browser/component_updater/chrome_component_updater_configurator.h"
+#include "components/component_updater/component_updater_switches.h"
+#include "components/update_client/configurator.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
+
+namespace component_updater {
+
+TEST(ChromeComponentUpdaterConfiguratorTest, TestDisablePings) {
+  base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();
+  cmdline->AppendSwitchASCII(switches::kComponentUpdater, "disable-pings");
+
+  const update_client::Configurator* config =
+      MakeChromeComponentUpdaterConfigurator(cmdline, NULL);
+
+  std::vector<GURL> pingUrls = config->PingUrl();

[Sorin Jianu, 2015/03/24 23:05:32]

Small deal, we could use a const declaration for the local variables that we
don't modify.

+  EXPECT_TRUE(pingUrls.empty());
+}
+
+TEST(ChromeComponentUpdaterConfiguratorTest, TestFastUpdate) {
+  base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();
+  cmdline->AppendSwitchASCII(switches::kComponentUpdater, "fast-update");
+
+  const update_client::Configurator* config =
+      MakeChromeComponentUpdaterConfigurator(cmdline, NULL);
+
+  ASSERT_EQ(1, config->InitialDelay());
+}
+
+TEST(ChromeComponentUpdaterConfiguratorTest, TestOverrideUrl) {
+  const char overrideUrl[] = "http://0.0.0.0/";
+
+  base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();
+  std::string val = "url-source";
+  val.append("=");
+  val.append(overrideUrl);
+  cmdline->AppendSwitchASCII(switches::kComponentUpdater, val.c_str());
+
+  const update_client::Configurator* config =
+      MakeChromeComponentUpdaterConfigurator(cmdline, NULL);
+
+  std::vector<GURL> urls = config->UpdateUrl();
+
+  ASSERT_EQ(1U, urls.size());
+  ASSERT_EQ(overrideUrl, urls.at(0).possibly_invalid_spec());

[Sorin Jianu, 2015/03/24 23:05:32]

Can we test that the actual URL is the same as the expected URL previously set?

[Sorin Jianu, 2015/03/25 19:25:13]

I apologize, I misread the code. Is there a reason we call possibly_invalid_spec
instead of spec? Is http://0.0.0.0/ invalid?

+}
+
+TEST(ChromeComponentUpdaterConfiguratorTest, TestSwitchRequestParam) {
+  base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();
+  cmdline->AppendSwitchASCII(switches::kComponentUpdater, "test-request");
+
+  const update_client::Configurator* config =
+      MakeChromeComponentUpdaterConfigurator(cmdline, NULL);
+
+  EXPECT_FALSE(config->ExtraRequestParams().empty());
+}
+
+}  // namespace component_updater