Fix for menus blocking user activity detection (Retry).

Fix for menus blocking user activity detection (Retry).

Original CL reverted here: https://codereview.chromium.org/998603003/

Menus used to block detecting user activity. The fix works by making the
UserActivityDetector a PlatformEventObserver rather than an
EventHandler.
Also made sure that PlatformEventSource has an instance in
ozone_platform_test.cc

TBR=oshima@chromium.org,jamescook@chromium.org
R=sadrul@chromium.org,alexst@chromium.org
BUG=462735
TEST=ui_base_unittests --gtest_filter=UserActivityDetectorTest.*

Committed: https://crrev.com/00e8cbeb43eb3cc99ffed3bc29a8a539dfece0a6
Cr-Commit-Position: refs/heads/master@{#321066}

[afakhry, 2015-03-16 22:13:56]

afakhry@chromium.org changed reviewers:
+ alexst@chromium.org, jamescook@chromium.org, oshima@chromium.org

[afakhry, 2015-03-16 23:54:32]

afakhry@chromium.org changed reviewers:
- jamescook@chromium.org, oshima@chromium.org

[afakhry, 2015-03-16 23:58:51]

@Sadrul: as greed on IM, I added the stub test implementation for
PlatformEventSource to ozone_platform_test.cc in order to prevent the ash tests
from crashing when using ozone.

@alexst: Could you please review the change in ozone_platform_test.cc?

[alexst (slow to review), 2015-03-17 01:51:22]

alexst@chromium.org changed reviewers:
+ spang@chromium.org

[alexst (slow to review), 2015-03-17 01:51:59]

spang knows this part better.

[sadrul, 2015-03-17 16:37:22]

On 2015/03/16 23:58:51, afakhry wrote:
> @Sadrul: as greed on IM, I added the stub test implementation for
> PlatformEventSource to ozone_platform_test.cc in order to prevent the ash
tests
> from crashing when using ozone.

Did any other part of the code change from the reverted one? (when re-landing a
reverted CL, please upload the reverted CL as the first patchset, so that it is
easier to see what changed)

> 
> @alexst: Could you please review the change in ozone_platform_test.cc?

[afakhry, 2015-03-17 16:45:04]

On 2015/03/17 16:37:22, sadrul wrote:
> On 2015/03/16 23:58:51, afakhry wrote:
> > @Sadrul: as greed on IM, I added the stub test implementation for
> > PlatformEventSource to ozone_platform_test.cc in order to prevent the ash
> tests
> > from crashing when using ozone.
> 
> Did any other part of the code change from the reverted one? (when re-landing
a
> reverted CL, please upload the reverted CL as the first patchset, so that it
is
> easier to see what changed)
> 
> > 
> > @alexst: Could you please review the change in ozone_platform_test.cc?

Nothing has changed. Only new change is in ozone_platform_test.cc.

[sadrul, 2015-03-17 16:48:51]

lgtm

[spang, 2015-03-17 16:53:26]

On 2015/03/17 16:37:22, sadrul wrote:
> On 2015/03/16 23:58:51, afakhry wrote:
> > @Sadrul: as greed on IM, I added the stub test implementation for
> > PlatformEventSource to ozone_platform_test.cc in order to prevent the ash
> tests
> > from crashing when using ozone.
> 
> Did any other part of the code change from the reverted one? (when re-landing
a
> reverted CL, please upload the reverted CL as the first patchset, so that it
is
> easier to see what changed)
> 
> > 
> > @alexst: Could you please review the change in ozone_platform_test.cc?

I'm disappointed we're adding more uses PlatformEvent for this. This is pretty
painful for us and sets us back on fixing warts such as
https://chromium.googlesource.com/chromium/src/+/master/ui/events/ozone/event....
I think we'll actually have to revert this change back once we allow menus to
work without using NativeEvent.

Anyway, the change to ui/ozone/platform/test is fine. ui/ozone lgtm.

[afakhry, 2015-03-18 01:07:56]

afakhry@chromium.org changed reviewers:
- alexst@chromium.org

[afakhry, 2015-03-18 01:10:32]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2015-03-18 01:11:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1013003002/1

[commit-bot: I haz the power, 2015-03-18 03:05:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-18 03:06:11]

Patchset 1 (id:??) landed as
https://crrev.com/00e8cbeb43eb3cc99ffed3bc29a8a539dfece0a6
Cr-Commit-Position: refs/heads/master@{#321066}

[afakhry, 2015-03-18 20:45:25]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1016173002/ by afakhry@chromium.org.

The reason for reverting is: Issue 468442 has resulted from this CL. A fix at a
higher level must be done before this CL can be relanded..