Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chrome/common/extensions/api/browser.idl

Issue 1012953004: Remove reference to OpenTabOptions in chrome.browser.openTab docs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/browser.idl
diff --git a/chrome/common/extensions/api/browser.idl b/chrome/common/extensions/api/browser.idl
index e53c0eb785855a155b0455a2107bd578aca2272c..ff61e779e4e04c4cacc0b0d68188eb2e78a759a3 100644
--- a/chrome/common/extensions/api/browser.idl
+++ b/chrome/common/extensions/api/browser.idl
@@ -16,10 +16,7 @@ namespace browser {
interface Functions {
// Opens a new tab in a browser window associated with the current
// application and Chrome profile. If no browser window for the Chrome
- // profile is opened, a new one is opened prior to creating the new tab. The
- // initial URL of the new tab is specified in |options|.
- // |options| : The $(ref:OpenTabOptions) for this function.
not at google - send to devlin 2015/03/16 22:21:16 Tautological, since docs will generate this alread
rpaquay 2015/03/16 22:29:23 Acknowledged.
- // |callback| : Called to indicate success or failure.
not at google - send to devlin 2015/03/16 22:21:16 Not true - it's a void callback.
rpaquay 2015/03/16 22:29:23 The intent was to communicate that success/failure
not at google - send to devlin 2015/03/16 22:33:51 That sounds like a good thing to do.
+ // profile is opened, a new one is opened prior to creating the new tab.
static void openTab(OpenTabOptions options,
optional Callback callback);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698