Remove reference to OpenTabOptions in chrome.browser.openTab docs.

Remove reference to OpenTabOptions in chrome.browser.openTab docs.

BUG=358315
R=rpaquay@chromium.org

Committed: https://crrev.com/c717364060b2420aab17eeea247a9c7460c0f23e
Cr-Commit-Position: refs/heads/master@{#320833}

[not at google - send to devlin, 2015-03-16 22:21:16]

Broken link is here -
https://developer.chrome.com/apps/browser#property-openTab-options

With this patch -
https://developer.chrome.com/_patch/1012953004/apps/browser#property-openTab-...

https://codereview.chromium.org/1012953004/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/browser.idl (left):

https://codereview.chromium.org/1012953004/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/browser.idl:21: // |options|  : The
$(ref:OpenTabOptions) for this function.
Tautological, since docs will generate this already - and it'll inline
OpenTabOptions, which is why the link results in a broken link.

https://codereview.chromium.org/1012953004/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/browser.idl:22: // |callback| : Called to indicate
success or failure.
Not true - it's a void callback.

[rpaquay, 2015-03-16 22:29:23]

https://codereview.chromium.org/1012953004/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/browser.idl (left):

https://codereview.chromium.org/1012953004/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/browser.idl:21: // |options|  : The
$(ref:OpenTabOptions) for this function.
On 2015/03/16 22:21:16, kalman wrote:
> Tautological, since docs will generate this already - and it'll inline
> OpenTabOptions, which is why the link results in a broken link.

Acknowledged.

https://codereview.chromium.org/1012953004/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/browser.idl:22: // |callback| : Called to indicate
success or failure.
On 2015/03/16 22:21:16, kalman wrote:
> Not true - it's a void callback.

The intent was to communicate that success/failure should be checked through
"chrome.runtime.lastError" when |callback| is invoked.

[not at google - send to devlin, 2015-03-16 22:33:51]

Added a longer comment. _patch URL hasn't been updated, I guess it has a bug.

https://codereview.chromium.org/1012953004/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/browser.idl (left):

https://codereview.chromium.org/1012953004/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/browser.idl:22: // |callback| : Called to indicate
success or failure.
On 2015/03/16 22:29:23, rpaquay wrote:
> On 2015/03/16 22:21:16, kalman wrote:
> > Not true - it's a void callback.
> 
> The intent was to communicate that success/failure should be checked through
> "chrome.runtime.lastError" when |callback| is invoked.

That sounds like a good thing to do.

[rpaquay, 2015-03-16 22:42:20]

lgtm

[not at google - send to devlin, 2015-03-16 22:52:29]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2015-03-16 22:52:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1012953004/20001

[commit-bot: I haz the power, 2015-03-17 00:53:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-17 00:53:50]

Patchset 2 (id:??) landed as
https://crrev.com/c717364060b2420aab17eeea247a9c7460c0f23e
Cr-Commit-Position: refs/heads/master@{#320833}