Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: tests/lib/async/stream_periodic3_test.dart

Issue 101293006: Revert "Fix VM timer firing too early." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/lib/async/multiple_timer_test.dart ('k') | tests/lib/async/timer_isolate_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // Test merging streams. 5 // Test merging streams.
6 library dart.test.stream_from_iterable; 6 library dart.test.stream_from_iterable;
7 7
8 import "dart:async"; 8 import "dart:async";
9 import '../../../pkg/unittest/lib/unittest.dart'; 9 import '../../../pkg/unittest/lib/unittest.dart';
10 10
11 // The stopwatch is more precise than the Timer. 11 // The stopwatch is more precise than the Timer. It can happen that
12 // the TIMEOUT triggers *slightly* too early on the VM. So we add a millisecond
13 // as safetymargin.
12 // Some browsers (Firefox and IE so far) can trigger too early. So we add more 14 // Some browsers (Firefox and IE so far) can trigger too early. So we add more
13 // margin. We use identical(1, 1.0) as an easy way to know if the test is 15 // margin. We use identical(1, 1.0) as an easy way to know if the test is
14 // compiled by dart2js. 16 // compiled by dart2js.
15 int get safetyMargin => identical(1, 1.0) ? 5 : 0; 17 int get safetyMargin => identical(1, 1.0) ? 5 : 1;
16 18
17 main() { 19 main() {
18 test("stream-periodic3", () { 20 test("stream-periodic3", () {
19 Stopwatch watch = new Stopwatch()..start(); 21 Stopwatch watch = new Stopwatch()..start();
20 Stream stream = new Stream.periodic(const Duration(milliseconds: 1), 22 Stream stream = new Stream.periodic(const Duration(milliseconds: 1),
21 (x) => x); 23 (x) => x);
22 stream.take(10).listen((_) { }, onDone: expectAsync0(() { 24 stream.take(10).listen((_) { }, onDone: expectAsync0(() {
23 int millis = watch.elapsedMilliseconds + safetyMargin; 25 int millis = watch.elapsedMilliseconds + safetyMargin;
24 expect(millis, greaterThan(10)); 26 expect(millis, greaterThan(10));
25 })); 27 }));
26 }); 28 });
27 } 29 }
OLDNEW
« no previous file with comments | « tests/lib/async/multiple_timer_test.dart ('k') | tests/lib/async/timer_isolate_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698