components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc - Issue 1012923003: Fix race in DataReductionProxyService read/write.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc

Issue 1012923003: Fix race in DataReductionProxyService read/write. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bengr CR comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc

index 51afeba981c27de1945f12d7e7cadaa5c971d268..c57dc2cbd0ba1606bba78086966df723d87fadcf 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc

@@ -116,7 +116,7 @@ class DataReductionProxyUsageStatsTest : public testing::Test {

return make_scoped_ptr(

new DataReductionProxyUsageStats(

test_context_->config(),

- test_context_->data_reduction_proxy_service()->GetWeakPtr(),

+ test_context_->unreachable_callback(),

test_context_->task_runner())).Pass();

}

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.cc ('k') | no next file » | no next file with comments »