components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc - Issue 1012923003: Fix race in DataReductionProxyService read/write.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

Issue 1012923003: Fix race in DataReductionProxyService read/write. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bengr CR comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

index 75e40d87f228028f7f8d4de8a363a05cb48e90c4..ba34dc762481ba4603120b54ba37c20795662ed4 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

@@ -120,7 +120,7 @@ class DataReductionProxyProtocolTest : public testing::Test {

context_->set_http_user_agent_settings(&http_user_agent_settings_);

usage_stats_.reset(new DataReductionProxyUsageStats(

test_context_->config(),

- test_context_->data_reduction_proxy_service()->GetWeakPtr(),

+ test_context_->unreachable_callback(),

test_context_->task_runner()));

DataReductionProxyInterceptor* interceptor =

« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h » ('j') | no next file with comments »