Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1419)

Unified Diff: cc/surfaces/display_scheduler.cc

Issue 1012853003: Add DisplayScheduler for Surfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DisplaySchedulerClient in preparation of unittests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/display_scheduler.cc
diff --git a/cc/surfaces/display_scheduler.cc b/cc/surfaces/display_scheduler.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0de441bf1e482c1f9e9da610fbcf4a4062a349c5
--- /dev/null
+++ b/cc/surfaces/display_scheduler.cc
@@ -0,0 +1,253 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "cc/surfaces/display_scheduler.h"
+
+#include <vector>
+
+#include "base/stl_util.h"
+#include "base/trace_event/trace_event.h"
+#include "cc/output/output_surface.h"
+#include "ui/gfx/frame_time.h"
+
+namespace cc {
+
+DisplayScheduler::DisplayScheduler(
+ DisplaySchedulerClient* client,
+ OutputSurface* output_surface,
+ int max_pending_swaps,
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner)
+ : client_(client),
+ output_surface_(output_surface),
+ task_runner_(task_runner),
+ vsync_observer_(nullptr),
+ output_surface_lost_(false),
+ inside_begin_frame_deadline_interval_(false),
+ resources_locked_by_browser_(true),
+ needs_draw_(false),
+ entire_display_damaged_(false),
+ all_active_surfaces_ready_to_draw_(false),
+ pending_swaps_(0),
+ max_pending_swaps_(max_pending_swaps),
+ weak_ptr_factory_(this) {
+ auto synthtic_begin_frame_source = SyntheticBeginFrameSource::Create(
+ task_runner_.get(), gfx::FrameTime::Now(),
+ BeginFrameArgs::DefaultInterval());
+ vsync_observer_ = synthtic_begin_frame_source.get();
+ begin_frame_source_ = synthtic_begin_frame_source.Pass();
+ begin_frame_source_->AddObserver(this);
+
+ begin_impl_frame_deadline_closure_ = base::Bind(
+ &DisplayScheduler::OnBeginFrameDeadline, weak_ptr_factory_.GetWeakPtr());
+}
+
+DisplayScheduler::~DisplayScheduler() {
+}
+
+void DisplayScheduler::SetAuthoritativeVSyncInterval(
brianderson 2015/04/07 02:32:19 Got rid of this for now. We can add it when it's a
+ const base::TimeDelta& interval) {
+ authoritative_vsync_interval_ = interval;
+ if (vsync_observer_)
+ vsync_observer_->OnUpdateVSyncParameters(last_vsync_timebase_, interval);
+}
+
+void DisplayScheduler::CommitVSyncParameters(base::TimeTicks timebase,
+ base::TimeDelta interval) {
+ TRACE_EVENT2("cc", "DisplayScheduler::CommitVSyncParameters", "timebase",
+ (timebase - base::TimeTicks()).InSecondsF(), "interval",
+ interval.InSecondsF());
+
+ if (authoritative_vsync_interval_ != base::TimeDelta()) {
+ interval = authoritative_vsync_interval_;
+ } else if (interval == base::TimeDelta()) {
+ // TODO(brianderson): We should not be receiving 0 intervals.
+ interval = BeginFrameArgs::DefaultInterval();
+ }
+
+ last_vsync_timebase_ = timebase;
+
+ if (vsync_observer_)
+ vsync_observer_->OnUpdateVSyncParameters(timebase, interval);
+}
+
+// If we try to draw when the Browser has locked it's resources, the
+// draw will fail.
+void DisplayScheduler::SetResourcesLockedByBrowser(bool locked) {
+ resources_locked_by_browser_ = locked;
+}
+
+// Notification that there was a resize or the root surface changed and
+// that we should just draw immediately.
+void DisplayScheduler::EntireDisplayDamaged() {
+ TRACE_EVENT0("cc", "DisplayScheduler::EntireDisplayDamaged");
+ needs_draw_ = true;
+ entire_display_damaged_ = true;
+}
+
+// Indicates that there was damage to one of the surfaces.
+// Has some logic to wait for multiple active surfaces before
+// triggering the deadline.
+void DisplayScheduler::SurfaceDamaged(SurfaceId surface_id) {
+ TRACE_EVENT1("cc", "DisplayScheduler::SurfaceDamaged", "surface_id",
+ surface_id.id);
+
+ needs_draw_ = true;
+
+ surface_ids_damaged_.insert(surface_id);
+
+ // TODO(mithro): Use hints from SetNeedsBeginFrames.
+ all_active_surfaces_ready_to_draw_ = base::STLIncludes(
+ surface_ids_damaged_, surface_ids_to_expect_damage_from_);
+
+ begin_frame_source_->SetNeedsBeginFrames(!output_surface_lost_);
+ ScheduleBeginFrameDeadline();
+}
+
+void DisplayScheduler::OutputSurfaceLost() {
+ TRACE_EVENT0("cc", "DisplayScheduler::OutputSurfaceLost");
+ output_surface_lost_ = true;
+ begin_frame_source_->SetNeedsBeginFrames(false);
+ ScheduleBeginFrameDeadline();
+}
+
+void DisplayScheduler::Draw() {
+ TRACE_EVENT0("cc", "DisplayScheduler::Draw");
+ DCHECK_LT(pending_swaps_, max_pending_swaps_);
+ DCHECK(!output_surface_lost_);
+
+ needs_draw_ = false;
+ entire_display_damaged_ = false;
+ all_active_surfaces_ready_to_draw_ = false;
+
+ client_->Draw();
+
+ surface_ids_to_expect_damage_from_ =
+ base::STLSetUnion<std::vector<SurfaceId>>(surface_ids_damaged_,
+ surface_ids_damaged_prev_);
+
+ surface_ids_damaged_prev_.swap(surface_ids_damaged_);
+ surface_ids_damaged_.clear();
+}
+
+bool DisplayScheduler::OnBeginFrameMixInDelegate(const BeginFrameArgs& args) {
+ TRACE_EVENT1("cc", "DisplayScheduler::BeginFrame", "args", args.AsValue());
+
+ // If we get another BeginFrame before the previous deadline,
+ // synchronously trigger the previous deadline before progressing.
+ if (inside_begin_frame_deadline_interval_) {
+ OnBeginFrameDeadline();
+ }
+
+ // Schedule the deadline.
+ current_begin_frame_args_ = args;
+ current_begin_frame_args_.deadline -=
+ BeginFrameArgs::DefaultEstimatedParentDrawTime();
+ inside_begin_frame_deadline_interval_ = true;
+ ScheduleBeginFrameDeadline();
+
+ return true;
+}
+
+base::TimeTicks DisplayScheduler::DesiredBeginFrameDeadlineTime() {
+ if (output_surface_lost_) {
+ TRACE_EVENT_INSTANT0("cc", "Lost output surface", TRACE_EVENT_SCOPE_THREAD);
+ return base::TimeTicks();
+ }
+
+ if (pending_swaps_ >= max_pending_swaps_) {
+ TRACE_EVENT_INSTANT0("cc", "Swap throttled", TRACE_EVENT_SCOPE_THREAD);
+ return current_begin_frame_args_.frame_time +
+ current_begin_frame_args_.interval;
+ }
+
+ if (resources_locked_by_browser_) {
+ TRACE_EVENT_INSTANT0("cc", "Resources locked by Browser",
+ TRACE_EVENT_SCOPE_THREAD);
+ return current_begin_frame_args_.frame_time +
+ current_begin_frame_args_.interval;
+ }
+
+ if (entire_display_damaged_) {
+ TRACE_EVENT_INSTANT0("cc", "Entire display damaged",
+ TRACE_EVENT_SCOPE_THREAD);
+ return base::TimeTicks();
+ }
+
+ if (all_active_surfaces_ready_to_draw_) {
+ TRACE_EVENT_INSTANT0("cc", "Active surfaces ready",
+ TRACE_EVENT_SCOPE_THREAD);
+ return base::TimeTicks();
+ }
+
+ if (needs_draw_) {
+ TRACE_EVENT_INSTANT0("cc", "More damage expected soon",
+ TRACE_EVENT_SCOPE_THREAD);
+ return current_begin_frame_args_.deadline;
+ }
+
+ TRACE_EVENT_INSTANT0("cc", "No damage yet", TRACE_EVENT_SCOPE_THREAD);
+ return current_begin_frame_args_.frame_time +
+ current_begin_frame_args_.interval;
+}
+
+void DisplayScheduler::ScheduleBeginFrameDeadline() {
+ TRACE_EVENT0("cc", "DisplayScheduler::ScheduleBeginFrameDeadline");
+
+ // We need to wait for the next BeginFrame before scheduling a deadline.
+ if (!inside_begin_frame_deadline_interval_) {
+ TRACE_EVENT_INSTANT0("cc", "Waiting for next BeginFrame",
+ TRACE_EVENT_SCOPE_THREAD);
+ DCHECK(begin_impl_frame_deadline_task_.IsCancelled());
+ return;
+ }
+
+ // Determine the deadline we want to use.
+ base::TimeTicks desired_deadline = DesiredBeginFrameDeadlineTime();
+
+ // Avoid re-scheduling the deadline if it's already correctly scheduled.
+ if (!begin_impl_frame_deadline_task_.IsCancelled() &&
+ desired_deadline == begin_impl_frame_deadline_task_time_)
+ return;
+
+ // Schedule the deadline.
+ begin_impl_frame_deadline_task_time_ = desired_deadline;
+ begin_impl_frame_deadline_task_.Cancel();
+ begin_impl_frame_deadline_task_.Reset(begin_impl_frame_deadline_closure_);
+
+ base::TimeDelta delta =
+ std::max(base::TimeDelta(), desired_deadline - base::TimeTicks::Now());
+ task_runner_->PostDelayedTask(
+ FROM_HERE, begin_impl_frame_deadline_task_.callback(), delta);
+}
+
+void DisplayScheduler::OnBeginFrameDeadline() {
+ TRACE_EVENT0("cc", "DisplayScheduler::OnBeginFrameDeadline");
+ begin_impl_frame_deadline_task_.Cancel();
+ begin_impl_frame_deadline_task_time_ = base::TimeTicks();
+
+ if (needs_draw_ && !output_surface_lost_) {
+ if (pending_swaps_ < max_pending_swaps_)
+ Draw();
+ } else {
+ begin_frame_source_->SetNeedsBeginFrames(false);
+ }
+
+ inside_begin_frame_deadline_interval_ = false;
+ begin_frame_source_->DidFinishFrame(0);
+}
+
+void DisplayScheduler::DidSwapBuffers() {
+ pending_swaps_++;
+ TRACE_EVENT1("cc", "DisplayScheduler::DidSwapBuffers", "pending_frames",
+ pending_swaps_);
+}
+
+void DisplayScheduler::DidSwapBuffersComplete() {
+ pending_swaps_--;
+ TRACE_EVENT1("cc", "DisplayScheduler::DidSwapBuffersComplete",
+ "pending_frames", pending_swaps_);
+ ScheduleBeginFrameDeadline();
+}
+
+} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698