Add DisplayScheduler for Surfaces

cc/surfaces/display.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/surfaces/display.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/trace_event/trace_event.h"
 #include "cc/debug/benchmark_instrumentation.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/output/compositor_frame_ack.h"
 #include "cc/output/direct_renderer.h"
 #include "cc/output/gl_renderer.h"
 #include "cc/output/renderer_settings.h"
 #include "cc/output/software_renderer.h"
 #include "cc/resources/texture_mailbox_deleter.h"
 #include "cc/surfaces/display_client.h"
+#include "cc/surfaces/display_scheduler.h"
 #include "cc/surfaces/surface.h"
 #include "cc/surfaces/surface_aggregator.h"
 #include "cc/surfaces/surface_manager.h"
 #include "cc/trees/blocking_task_runner.h"
 
 namespace cc {
 
 Display::Display(DisplayClient* client,
                  SurfaceManager* manager,
                  SharedBitmapManager* bitmap_manager,
                  gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
                  const RendererSettings& settings)
     : client_(client),
       manager_(manager),
       bitmap_manager_(bitmap_manager),
       gpu_memory_buffer_manager_(gpu_memory_buffer_manager),
       settings_(settings),
+      current_surface_has_resources_(false),

[brianderson, 2015/04/03 01:35:48]

jbauman: Can you check my logic for how I update this variable? It seems to
work, but I'm worried about corner cases.

Is there a better way to let the DisplayScheduler know that draws will fail
because the Browser has locked its resources?

       device_scale_factor_(1.f),
+      scheduler_(nullptr),
       blocking_main_thread_task_runner_(
           BlockingTaskRunner::Create(base::MessageLoopProxy::current())),
       texture_mailbox_deleter_(
           new TextureMailboxDeleter(base::MessageLoopProxy::current())) {
   manager_->AddObserver(this);
 }
 
 Display::~Display() {
   manager_->RemoveObserver(this);
   if (aggregator_) {
     for (const auto& id_entry : aggregator_->previous_contained_surfaces()) {
       Surface* surface = manager_->GetSurfaceForId(id_entry.first);
       if (surface)
         surface->RunDrawCallbacks(SurfaceDrawStatus::DRAW_SKIPPED);
     }
   }
 }
 
-bool Display::Initialize(scoped_ptr<OutputSurface> output_surface) {
+bool Display::Initialize(scoped_ptr<OutputSurface> output_surface,
+                         DisplayScheduler* scheduler) {
   output_surface_ = output_surface.Pass();
+  scheduler_ = scheduler;
   return output_surface_->BindToClient(this);
 }
 
 void Display::SetSurfaceId(SurfaceId id, float device_scale_factor) {
+  if (current_surface_id_ == id && device_scale_factor_ == device_scale_factor)

[brianderson, 2015/04/03 01:35:48]

jbauman: Is this early return ok to avoid calling EntireDisplayDamaged()?

[jbauman, 2015/04/03 22:27:51]

In general this should be ok, as OnSurfaceDamaged should be called otherwise to
damage the Surface.

+    return;
+
   current_surface_id_ = id;
+
+  current_surface_has_resources_ = true;
+  Surface* surface = manager_->GetSurfaceForId(id);
+  if (surface) {
+    const CompositorFrame* current_frame = surface->GetEligibleFrame();
+    if (!current_frame || !current_frame->delegated_frame_data ||
+        !current_frame->delegated_frame_data->resource_list.size()) {
+      current_surface_has_resources_ = false;
+    }
+  }
+
   device_scale_factor_ = device_scale_factor;
-  client_->DisplayDamaged();
+  if (scheduler_)
+    scheduler_->EntireDisplayDamaged();
 }
 
 void Display::Resize(const gfx::Size& size) {
   if (size == current_surface_size_)
     return;
   // Need to ensure all pending swaps have executed before the window is
   // resized, or D3D11 will scale the swap output.
   if (renderer_ && settings_.finish_rendering_on_resize)
     renderer_->Finish();
   current_surface_size_ = size;
-  client_->DisplayDamaged();
+  if (scheduler_)
+    scheduler_->EntireDisplayDamaged();
 }
 
 void Display::InitializeRenderer() {
   if (resource_provider_)
     return;
 
   scoped_ptr<ResourceProvider> resource_provider = ResourceProvider::Create(
       output_surface_.get(), bitmap_manager_, gpu_memory_buffer_manager_,
       blocking_main_thread_task_runner_.get(), settings_.highp_threshold_min,
       settings_.use_rgba_4444_textures,
@@ skipping 15 matching lines @@
       return;
     renderer_ = renderer.Pass();
   }
 
   resource_provider_ = resource_provider.Pass();
   aggregator_.reset(new SurfaceAggregator(manager_, resource_provider_.get()));
 }
 
 void Display::DidLoseOutputSurface() {
   client_->OutputSurfaceLost();
+  scheduler_->OutputSurfaceLost();
+}
+
+bool Display::CurrentSurfaceHasResources() {
+  return current_surface_has_resources_;
 }
 
 bool Display::Draw() {
   if (current_surface_id_.is_null())
     return false;
 
   InitializeRenderer();
   if (!output_surface_)
     return false;
 
@@ skipping 54 matching lines @@
                                 frame->metadata.latency_info.begin(),
                                 frame->metadata.latency_info.end());
     DidSwapBuffers();
     DidSwapBuffersComplete();
   }
 
   return true;
 }
 
 void Display::DidSwapBuffers() {
-  client_->DidSwapBuffers();
+  scheduler_->DidSwapBuffers();
 }
 
 void Display::DidSwapBuffersComplete() {
-  client_->DidSwapBuffersComplete();
+  scheduler_->DidSwapBuffersComplete();
 }
 
 void Display::CommitVSyncParameters(base::TimeTicks timebase,
                                     base::TimeDelta interval) {
   client_->CommitVSyncParameters(timebase, interval);
+  scheduler_->CommitVSyncParameters(timebase, interval);
 }
 
 void Display::SetMemoryPolicy(const ManagedMemoryPolicy& policy) {
   client_->SetMemoryPolicy(policy);
 }
 
 void Display::OnSurfaceDamaged(SurfaceId surface_id, bool* changed) {
   if (aggregator_ &&
       aggregator_->previous_contained_surfaces().count(surface_id)) {
     Surface* surface = manager_->GetSurfaceForId(surface_id);
+    bool has_resources = true;
     if (surface) {
       const CompositorFrame* current_frame = surface->GetEligibleFrame();
       if (!current_frame || !current_frame->delegated_frame_data ||
-          !current_frame->delegated_frame_data->resource_list.size())
+          !current_frame->delegated_frame_data->resource_list.size()) {
         aggregator_->ReleaseResources(surface_id);
+        has_resources = false;
+      }
     }
-    client_->DisplayDamaged();
+    if (surface_id == current_surface_id_)
+      current_surface_has_resources_ = has_resources;
+    scheduler_->SurfaceDamaged(surface_id);
     *changed = true;
   } else if (surface_id == current_surface_id_) {
-    client_->DisplayDamaged();
+    current_surface_has_resources_ = true;

[jbauman, 2015/04/03 22:27:51]

This may not necessarily be true - we probably need to do the same check as
above.

+    scheduler_->SurfaceDamaged(surface_id);
     *changed = true;
   }
 }
 
 SurfaceId Display::CurrentSurfaceId() {
   return current_surface_id_;
 }
 
 int Display::GetMaxFramesPending() {
   int max_frames_pending =
       output_surface_ ? output_surface_->capabilities().max_frames_pending : 0;
   if (max_frames_pending <= 0)
     max_frames_pending = OutputSurface::DEFAULT_MAX_FRAMES_PENDING;
   return max_frames_pending;
 }
 
 }  // namespace cc