chrome/test/data/password/password_xhr_submit.html - Issue 1012853002: [Password Manager] Use successful XHR submission as a signal for password saving

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/password/password_xhr_submit.html

Issue 1012853002: [Password Manager] Use successful XHR submission as a signal for password saving (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | components/autofill/content/renderer/autofill_agent.h » ('j') | components/autofill/content/renderer/password_autofill_agent.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/password/password_xhr_submit.html

diff --git a/chrome/test/data/password/password_xhr_submit.html b/chrome/test/data/password/password_xhr_submit.html

index 67ec93e2b8b0567b979a6dbda02f2efd3d13afe6..bc32409fa055085b5f9373e5b6bbfe96d0744e45 100644

--- a/chrome/test/data/password/password_xhr_submit.html

+++ b/chrome/test/data/password/password_xhr_submit.html

@@ -2,9 +2,30 @@

<head>

+var navigate = true;

+// TODO(gcasto): Not sure why this is necessary, but calling

+// window.domAutomationController directly in setTimeout seemt to causes the

+// function to be evaluated inline.

+function delayedUpload() {

+ window.domAutomationController.send("XHR_FINISHED");

function state_changed(xhr) {

- if (xhr.readyState == 4)

- window.top.location.href = "done.html";

+ if (xhr.readyState == 4) {

+ if (navigate) {

+ window.top.location.href = "done.html";

+ } else {

+ // Pretend like auth succeeded by hiding the login and signup forms.

+ document.getElementById("testform").style.display = "none";

+ document.getElementById("signup_testform").style.display = "none";

+ window.domAutomationController.setAutomationId(0);

+ // Delay upload so that handler in PasswordAutofillAgent can be run

+ // first. This will happen immediately after JS execution ends, so this

+ // shouldn't introduce any timing dependent flakes.

+ setTimeout(delayedUpload, 0);

+ }

}

function send_xhr() {