Add first implemenation for SU password sync

chrome/browser/chromeos/login/managed/locally_managed_user_creation_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/managed/locally_managed_user_creation_controller.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/sys_info.h"
 #include "base/task_runner_util.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/login/managed/locally_managed_user_constants.h"
+#include "chrome/browser/chromeos/login/managed/supervised_user_authentication.h"
 #include "chrome/browser/chromeos/login/mount_manager.h"
 #include "chrome/browser/chromeos/login/supervised_user_manager.h"
 #include "chrome/browser/chromeos/login/user.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/session_manager_client.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 115 matching lines @@
         ManagedUserRegistrationUtility::GenerateNewManagedUserId();
   }
 
   manager->CreateUserRecord(
       creation_context_->manager_id,
       creation_context_->local_user_id,
       creation_context_->sync_user_id,
       creation_context_->display_name);
 
   manager->SetCreationTransactionUserId(creation_context_->local_user_id);
+  SupervisedUserAuthentication* authentication =
+      manager->GetSupervisedUserAuthentication();
+  if (authentication->FillDataForNewUser(
+      creation_context_->local_user_id,

[Nikita (slow), 2013/12/09 16:42:16]

nit: Please move parameter to prev line and align 2 others with it.

[Denis Kuznetsov (DE-MUC), 2013/12/12 19:45:24]

Done.

+      creation_context_->password,
+      &creation_context_->password_data)) {
+    authentication->StorePasswordData(creation_context_->local_user_id,
+                                      creation_context_->password_data);
+  }
   VLOG(1) << "Creating cryptohome";
   authenticator_ = new ManagedUserAuthenticator(this);
-  authenticator_->AuthenticateToCreate(creation_context_->local_user_id,
-                                       creation_context_->password);
+  authenticator_->AuthenticateToCreate(

[Nikita (slow), 2013/12/09 16:42:16]

nit: Can you please change alignment in the same way here if possible.

[Denis Kuznetsov (DE-MUC), 2013/12/12 19:45:24]

Done.

+      creation_context_->local_user_id,
+      authentication->TransformPassword(
+          creation_context_->local_user_id,
+          creation_context_->password));
 }
 
 void LocallyManagedUserCreationController::OnAuthenticationFailure(
     ManagedUserAuthenticator::AuthState error) {
   timeout_timer_.Stop();
   ErrorCode code = NO_ERROR;
   switch (error) {
     case ManagedUserAuthenticator::NO_MOUNT:
       code = CRYPTOHOME_NO_MOUNT;
       break;
@@ skipping 17 matching lines @@
   if (creation_context_->creation_type == NEW_USER) {
     // Generate master password.
     char master_key_bytes[kMasterKeySize];
     crypto::RandBytes(&master_key_bytes, sizeof(master_key_bytes));
     creation_context_->master_key = StringToLowerASCII(base::HexEncode(
         reinterpret_cast<const void*>(master_key_bytes),
         sizeof(master_key_bytes)));
   }
 
   VLOG(1) << "Adding master key";
-  authenticator_->AddMasterKey(creation_context_->local_user_id,
-                               creation_context_->password,
-                               creation_context_->master_key);
+  SupervisedUserAuthentication* authentication = UserManager::Get()->
+      GetSupervisedUserManager()->GetSupervisedUserAuthentication();
+
+  authenticator_->AddMasterKey(

[Nikita (slow), 2013/12/09 16:42:16]

nit: Can you please change alignment in the same way here if possible.

[Denis Kuznetsov (DE-MUC), 2013/12/12 19:45:24]

Done.

+      creation_context_->local_user_id,
+      authentication->TransformPassword(
+          creation_context_->local_user_id,
+          creation_context_->password),
+      creation_context_->master_key);
 }
 
 void LocallyManagedUserCreationController::OnAddKeySuccess() {
   creation_context_->registration_utility =
       ManagedUserRegistrationUtility::Create(
           creation_context_->manager_profile);
 
   VLOG(1) << "Creating user on server";
+  // TODO(antrim) : add password data to sync once API is ready.

[Nikita (slow), 2013/12/09 16:42:16]

nit: Bug # is missing. Just to make sure that we're tracking this on crbug.com.

[Denis Kuznetsov (DE-MUC), 2013/12/12 19:45:24]

Done.

   ManagedUserRegistrationInfo info(creation_context_->display_name,
                                    creation_context_->avatar_index);
   info.master_key = creation_context_->master_key;
   timeout_timer_.Stop();
   creation_context_->registration_utility->Register(
       creation_context_->sync_user_id,
       info,
       base::Bind(&LocallyManagedUserCreationController::RegistrationCallback,
                  weak_factory_.GetWeakPtr()));
 }
@@ skipping 66 matching lines @@
   // sync service fails to use it.
   UserManager::Get()->SaveUserOAuthStatus(creation_context_->local_user_id,
                                           User::OAUTH2_TOKEN_STATUS_VALID);
   UserManager::Get()->GetSupervisedUserManager()->
       CommitCreationTransaction();
   if (consumer_)
     consumer_->OnCreationSuccess();
 }
 
 }  // namespace chromeos