SyncFS: Fix conflict resolver for multiple parents

chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/drive_backend/conflict_resolver.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/run_loop.h"
@@ skipping 122 matching lines @@
   std::string CreateRemoteFile(const std::string& parent_folder_id,
                                const std::string& title,
                                const std::string& content) {
     std::string file_id;
     EXPECT_EQ(google_apis::HTTP_SUCCESS,
               fake_drive_helper_->AddFile(
                   parent_folder_id, title, content, &file_id));
     return file_id;
   }
 
+  google_apis::GDataErrorCode AddFileToFolder(
+      const std::string& parent_folder_id,
+      const std::string& file_id) {
+    google_apis::GDataErrorCode error = google_apis::GDATA_OTHER_ERROR;
+    fake_drive_service_->AddResourceToDirectory(
+        parent_folder_id, file_id,
+        CreateResultReceiver(&error));
+    base::RunLoop().RunUntilIdle();
+    return error;
+  }
+
+  int CountParents(const std::string& file_id) {
+    scoped_ptr<google_apis::ResourceEntry> entry;
+    EXPECT_EQ(google_apis::HTTP_SUCCESS,
+              fake_drive_helper_->GetResourceEntry(file_id, &entry));
+    int count = 0;
+    const ScopedVector<google_apis::Link>& links = entry->links();
+    for (ScopedVector<google_apis::Link>::const_iterator itr = links.begin();
+        itr != links.end(); ++itr) {
+      if ((*itr)->type() == google_apis::Link::LINK_PARENT)
+        ++count;
+    }
+    return count;
+  }
+
   SyncStatusCode RunSyncer() {
     SyncStatusCode status = SYNC_STATUS_UNKNOWN;
     scoped_ptr<RemoteToLocalSyncer> syncer(new RemoteToLocalSyncer(this));
     syncer->Run(CreateResultReceiver(&status));
     base::RunLoop().RunUntilIdle();
     return status;
   }
 
   void RunSyncerUntilIdle() {
     SyncStatusCode status = SYNC_STATUS_UNKNOWN;
@@ skipping 135 matching lines @@
   ScopedVector<google_apis::ResourceEntry> entries =
       GetResourceEntriesForParentAndTitle(app_root, kTitle);
   ASSERT_EQ(4u, entries.size());
 
   // Only primary file should survive.
   EXPECT_EQ(SYNC_STATUS_OK, RunConflictResolver());
   VerifyConflictResolution(app_root, kTitle, primary,
                            google_apis::ENTRY_KIND_FOLDER);
 }
 
-// TODO(nhiroki): Add multi-parent resolution cases.
+TEST_F(ConflictResolverTest, ResolveMultiParents_File) {
+  const GURL kOrigin("chrome-extension://example");
+  const std::string sync_root = CreateSyncRoot();
+  const std::string app_root = CreateRemoteFolder(sync_root, kOrigin.host());
+  InitializeMetadataDatabase();
+  RegisterApp(kOrigin.host(), app_root);
+  RunSyncerUntilIdle();
+
+  const std::string primary = CreateRemoteFolder(app_root, "primary");
+  const std::string file = CreateRemoteFile(primary, "file", "data");
+  ASSERT_EQ(google_apis::HTTP_SUCCESS,
+            AddFileToFolder(CreateRemoteFolder(app_root, "nonprimary1"), file));
+  ASSERT_EQ(google_apis::HTTP_SUCCESS,
+            AddFileToFolder(CreateRemoteFolder(app_root, "nonprimary2"), file));
+  ASSERT_EQ(google_apis::HTTP_SUCCESS,
+            AddFileToFolder(CreateRemoteFolder(app_root, "nonprimary3"), file));
+
+  EXPECT_EQ(SYNC_STATUS_OK, ListChanges());
+  RunSyncerUntilIdle();
+
+  EXPECT_EQ(4, CountParents(file));
+
+  EXPECT_EQ(SYNC_STATUS_OK, RunConflictResolver());
+
+  EXPECT_EQ(1, CountParents(file));
+}
+
+TEST_F(ConflictResolverTest, ResolveMultiParents_Folder) {
+  const GURL kOrigin("chrome-extension://example");
+  const std::string sync_root = CreateSyncRoot();
+  const std::string app_root = CreateRemoteFolder(sync_root, kOrigin.host());
+  InitializeMetadataDatabase();
+  RegisterApp(kOrigin.host(), app_root);
+  RunSyncerUntilIdle();
+
+  const std::string primary = CreateRemoteFolder(app_root, "primary");
+  const std::string file = CreateRemoteFolder(primary, "folder");
+  ASSERT_EQ(google_apis::HTTP_SUCCESS,
+            AddFileToFolder(CreateRemoteFolder(app_root, "nonprimary1"), file));
+  ASSERT_EQ(google_apis::HTTP_SUCCESS,
+            AddFileToFolder(CreateRemoteFolder(app_root, "nonprimary2"), file));
+  ASSERT_EQ(google_apis::HTTP_SUCCESS,
+            AddFileToFolder(CreateRemoteFolder(app_root, "nonprimary3"), file));
+
+  EXPECT_EQ(SYNC_STATUS_OK, ListChanges());
+  RunSyncerUntilIdle();
+
+  EXPECT_EQ(4, CountParents(file));
+
+  EXPECT_EQ(SYNC_STATUS_OK, RunConflictResolver());
+
+  EXPECT_EQ(1, CountParents(file));
+}
 
 }  // namespace drive_backend
 }  // namespace sync_file_system