Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1012823002: Revert of Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the... (Closed)

Created:
5 years, 9 months ago by not at google - send to devlin
Modified:
5 years, 9 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim… (patchset #4 id:160001 of https://codereview.chromium.org/995983002/) Reason for revert: Crashes (see crbug.com/467353). Original issue's description: > Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct time. > > "Extensions.ExtensionHostMonitoring.NumLoaded" UMA is now correctly recorded. > I also cleaned up ExtensionHost a little to make it more obvious. > > R=yoz@chromium.org > TBR=sky@chromium.org > > Committed: https://crrev.com/4eefc7b64335c6008a1e5218c230dadd733875a7 > Cr-Commit-Position: refs/heads/master@{#320536} TBR=yoz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -181 lines) Patch
M chrome/browser/extensions/extension_view_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_host.h View 4 chunks +5 lines, -10 lines 0 comments Download
M extensions/browser/extension_host.cc View 6 chunks +31 lines, -41 lines 0 comments Download
M extensions/browser/lazy_background_task_queue.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/load_monitoring_extension_host_queue.h View 4 chunks +8 lines, -5 lines 0 comments Download
M extensions/browser/load_monitoring_extension_host_queue.cc View 4 chunks +22 lines, -9 lines 0 comments Download
M extensions/browser/load_monitoring_extension_host_queue_unittest.cc View 15 chunks +34 lines, -110 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
not at google - send to devlin
Created Revert of Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim…
5 years, 9 months ago (2015-03-16 17:06:30 UTC) #1
Yoyo Zhou
LGTM
5 years, 9 months ago (2015-03-16 17:43:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012823002/1
5 years, 9 months ago (2015-03-16 17:43:50 UTC) #6
not at google - send to devlin
You actually have to click [ ] to submit reverts. I didn't know that. Lucky ...
5 years, 9 months ago (2015-03-16 17:44:10 UTC) #7
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-16 17:44:39 UTC) #9
Yoyo Zhou
5 years, 9 months ago (2015-03-16 20:22:42 UTC) #11
crrev.com/320671 already reverts this, so I'm closing this one.

Powered by Google App Engine
This is Rietveld 408576698