Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1012773010: cleanup: Use ExtensionRegistryObserver in Uber (Closed)

Created:
5 years, 9 months ago by limasdf
Modified:
5 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cleanup: Use ExtensionRegistryObserver in Uber Use ExtensionRegistryObserver in Uber since ExtensionRegistry replaces chrome::extension notifications. BUG=411568 R=estade@chromium.org TEST=browser_test --gtest_filter=UberUIBrowserTest.HistoryOverride Committed: https://crrev.com/2166dd4a75f25f000dd10deecfecf0da3980b273 Cr-Commit-Position: refs/heads/master@{#322281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -54 lines) Patch
M chrome/browser/ui/webui/uber/uber_ui.h View 2 chunks +23 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 7 chunks +44 lines, -42 lines 0 comments Download
A chrome/browser/ui/webui/uber/uber_ui_browsertest.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
limasdf
Resubmit: original is https://codereview.chromium.org/321563007/ Hi. can I get LGTM again? Previous CL is created 9 ...
5 years, 9 months ago (2015-03-25 23:20:04 UTC) #1
Evan Stade
lgtm
5 years, 9 months ago (2015-03-25 23:22:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012773010/1
5 years, 9 months ago (2015-03-25 23:23:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 00:55:47 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 00:56:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2166dd4a75f25f000dd10deecfecf0da3980b273
Cr-Commit-Position: refs/heads/master@{#322281}

Powered by Google App Engine
This is Rietveld 408576698