Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1012773008: Make http_server part of the sdk. (Closed)

Created:
5 years, 9 months ago by DaveMoore
Modified:
5 years, 9 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Unecessary public_dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -226 lines) Patch
M examples/http_handler/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/http_handler/http_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/services/http_server/public/cpp/BUILD.gn View 1 chunk +7 lines, -1 line 0 comments Download
A + mojo/services/http_server/public/cpp/http_server_util.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/http_server/public/cpp/lib/http_server_util.cc View 2 chunks +8 lines, -9 lines 0 comments Download
A + mojo/services/http_server/public/interfaces/BUILD.gn View 1 chunk +5 lines, -4 lines 0 comments Download
A + mojo/services/http_server/public/interfaces/http_request.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/http_server/public/interfaces/http_response.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/http_server/public/interfaces/http_server.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/http_server/public/interfaces/http_server_factory.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/roll/rev_sdk.py View 1 chunk +1 line, -0 lines 0 comments Download
M services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/http_server/BUILD.gn View 1 2 chunks +4 lines, -4 lines 0 comments Download
M services/http_server/connection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/http_server/http_request_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M services/http_server/http_server_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/http_server/http_server_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/http_server/http_server_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/http_server/http_server_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/http_server/http_server_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M services/http_server/http_server_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
D services/http_server/public/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
D services/http_server/public/http_request.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
D services/http_server/public/http_response.mojom View 1 chunk +0 lines, -22 lines 0 comments Download
D services/http_server/public/http_server.mojom View 1 chunk +0 lines, -27 lines 0 comments Download
D services/http_server/public/http_server_factory.mojom View 1 chunk +0 lines, -27 lines 0 comments Download
D services/http_server/public/http_server_util.h View 1 chunk +0 lines, -17 lines 0 comments Download
D services/http_server/public/http_server_util.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M services/python/mojo_url_redirector/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M shell/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/shell_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/tools/debugger/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tools/debugger/debugger.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
DaveMoore
Unecessary public_dep
5 years, 9 months ago (2015-03-16 23:50:40 UTC) #1
DaveMoore
5 years, 9 months ago (2015-03-16 23:51:33 UTC) #2
DaveMoore
5 years, 9 months ago (2015-03-16 23:51:46 UTC) #4
jamesr
Mojo apps with published binaries/mojom files are not part of the SDK, they're published services. ...
5 years, 9 months ago (2015-03-16 23:55:43 UTC) #5
DaveMoore
5 years, 9 months ago (2015-03-17 00:09:16 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ab95e96a229e5287a61fd24296f0f9f15a7f0311 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698