Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1012753003: Check kMaxDescriptorsPerMessage in test_packaged_app.cc (Closed)

Created:
5 years, 9 months ago by Yusuke Sato
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check kMaxDescriptorsPerMessage in test_packaged_app.cc BUG=348232 BUG=nativeclient:3802 TEST=git cl try TEST=manually checked that 'ninja browser_tests' failed when kMaxDescriptorsPerMessage in test_packaged_app.cc was outdated. Committed: https://crrev.com/43d6a17f18b733f71e71e54e7675cbc7c8092510 Cr-Commit-Position: refs/heads/master@{#321208}

Patch Set 1 #

Patch Set 2 : review #

Total comments: 2

Patch Set 3 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M ppapi/tests/DEPS View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M ppapi/tests/extensions/packaged_app/test_packaged_app.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yusuke Sato
Please take a look.
5 years, 9 months ago (2015-03-17 01:51:43 UTC) #2
Mark Seaborn
LGTM https://codereview.chromium.org/1012753003/diff/20001/ppapi/tests/DEPS File ppapi/tests/DEPS (right): https://codereview.chromium.org/1012753003/diff/20001/ppapi/tests/DEPS#newcode28 ppapi/tests/DEPS:28: # defiend in ipc/ipc_message_attachment_set.h. "defined"
5 years, 9 months ago (2015-03-17 17:55:22 UTC) #3
Yusuke Sato
https://codereview.chromium.org/1012753003/diff/20001/ppapi/tests/DEPS File ppapi/tests/DEPS (right): https://codereview.chromium.org/1012753003/diff/20001/ppapi/tests/DEPS#newcode28 ppapi/tests/DEPS:28: # defiend in ipc/ipc_message_attachment_set.h. On 2015/03/17 17:55:22, Mark Seaborn ...
5 years, 9 months ago (2015-03-17 18:04:21 UTC) #4
Yusuke Sato
Dave (ppapi/ owner), Adam (ipc/ owner), please take a look. This is a follow-up CL ...
5 years, 9 months ago (2015-03-17 18:05:54 UTC) #6
dmichael (off chromium)
lgtm
5 years, 9 months ago (2015-03-17 18:29:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012753003/30001
5 years, 9 months ago (2015-03-18 20:10:53 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years, 9 months ago (2015-03-18 21:25:24 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 21:26:19 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/43d6a17f18b733f71e71e54e7675cbc7c8092510
Cr-Commit-Position: refs/heads/master@{#321208}

Powered by Google App Engine
This is Rietveld 408576698