Source/modules/accessibility/AXNodeObject.cpp - Issue 1012663002: Aria disabled does not apply to descendant elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 1012663002: Aria disabled does not apply to descendant elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed methods names to ..DisabledNode() Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXNodeObject.cpp

diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp

index c7aa9d355099f16ac6c8f915fc43ddb1347facbc..8bb62a70d5f0aad9855f8c3097aaec442a108296 100644

--- a/Source/modules/accessibility/AXNodeObject.cpp

+++ b/Source/modules/accessibility/AXNodeObject.cpp

@@ -730,7 +730,7 @@ bool AXNodeObject::isClickable() const

bool AXNodeObject::isEnabled() const

{

- if (equalIgnoringCase(getAttribute(aria_disabledAttr), "true"))

+ if (isDescendantOfDisabledNode())

return false;

Node* node = this->node();

« no previous file with comments | « LayoutTests/accessibility/aria-disabled-expected.txt ('k') | Source/modules/accessibility/AXObject.h » ('j') | no next file with comments »