Source/modules/accessibility/AXNodeObject.cpp - Issue 1012663002: Aria disabled does not apply to descendant elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 1012663002: Aria disabled does not apply to descendant elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Applied suggestions Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/accessibility/aria-disabled.html ('K') | « LayoutTests/accessibility/aria-disabled-expected.txt ('k') | Source/modules/accessibility/AXObject.h » ('j') | Source/modules/accessibility/AXObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXNodeObject.cpp

diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp

index 75cd4a77849ba1a7e80ddbcd4286a37584464f44..9e36afccc94e001a0296a76b4ec95b7daf6b6881 100644

--- a/Source/modules/accessibility/AXNodeObject.cpp

+++ b/Source/modules/accessibility/AXNodeObject.cpp

@@ -727,7 +727,7 @@ bool AXNodeObject::isClickable() const

bool AXNodeObject::isEnabled() const

{

- if (equalIgnoringCase(getAttribute(aria_disabledAttr), "true"))

+ if (isDescendantOfDisabledParent())

return false;

Node* node = this->node();