Aria disabled does not apply to descendant elements

Source/modules/accessibility/AXObject.cpp

 /*
  * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 350 matching lines @@
     AXObjectCacheImpl* cache = axObjectCache();
     if (!cache)
         return;
 
     if (cache->modificationCount() == m_lastModificationCount)
         return;
 
     m_lastModificationCount = cache->modificationCount();
     m_cachedIsInertOrAriaHidden = computeIsInertOrAriaHidden();
     m_cachedIsDescendantOfBarrenParent = computeIsDescendantOfBarrenParent();
+    m_cachedIsDescendantOfDisabledParent = computeIsDescendantOfDisabledParent();
     m_cachedIsIgnored = computeAccessibilityIsIgnored();
     m_cachedLiveRegionRoot = isLiveRegion() ?
         this :
         (parentObjectIfExists() ? parentObjectIfExists()->liveRegionRoot() : 0);
 }
 
 bool AXObject::accessibilityIsIgnoredByDefault() const
 {
     return defaultObjectInclusion() == IgnoreObject;
 }
@@ skipping 46 matching lines @@
 bool AXObject::computeIsDescendantOfBarrenParent() const
 {
     for (AXObject* object = parentObject(); object; object = object->parentObject()) {
         if (!object->canHaveChildren())
             return true;
     }
 
     return false;
 }
 
+bool AXObject::isDescendantOfDisabledParent() const
+{
+    updateCachedAttributeValuesIfNeeded();
+    return m_cachedIsDescendantOfDisabledParent;
+}
+
+bool AXObject::computeIsDescendantOfDisabledParent() const

[dmazzoni, 2015/03/23 16:16:51]

Please rewrite this to look more like computeIsInertOrAriaHidden instead.

Right now for every element on the page you're walking up all the parents to see
if it's disabled - but a faster way to do this is to check the current element,
then check the parent by calling isDescendantOfDisabledParent - then if the
parent was already computed you don't have to repeat that work.

computeIsDescendantOfBarrenParent could probably be improved too, but we don't
have to do it in this change.

+{
+    for (AXObject* parent = const_cast<AXObject*>(this); parent; parent = parent->parentObject()) {

[dmazzoni, 2015/03/23 16:16:51]

Why do you need the const_cast? Can you write it as:

    for (const AXObject* parent = this; ...

?

If not, that's okay, but try it that way first.

+        const AtomicString& disabled = parent->getAttribute(aria_disabledAttr);
+        if (equalIgnoringCase(disabled, "true"))
+            return true;
+        if (equalIgnoringCase(disabled, "false"))
+            return false;
+    }
+    return false;
+}
+
 bool AXObject::lastKnownIsIgnoredValue()
 {
     if (m_lastKnownIsIgnoredValue == DefaultBehavior)
         m_lastKnownIsIgnoredValue = accessibilityIsIgnored() ? IgnoreObject : IncludeObject;
 
     return m_lastKnownIsIgnoredValue == IgnoreObject;
 }
 
 void AXObject::setLastKnownIsIgnoredValue(bool isIgnored)
 {
@@ skipping 670 matching lines @@
 }
 
 const AtomicString& AXObject::roleName(AccessibilityRole role)
 {
     static const Vector<AtomicString>* roleNameVector = createRoleNameVector();
 
     return roleNameVector->at(role);
 }
 
 } // namespace blink