Chromium Code Reviews

Issue 1012633004: Revert of Remove ResourceFetcher's access to a real FetchContext at frame detach time (Closed)

Created:
5 years, 9 months ago by alph
Modified:
5 years, 9 months ago
Reviewers:
sof, Mike West, João Eiras, Nate Chapin
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, rwlbuis, sof, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Remove ResourceFetcher's access to a real FetchContext at frame detach time (patchset #2 id:20001 of https://codereview.chromium.org/1024263002/) Reason for revert: Suspect it responsible for http/tests/htmlimports/import-async-previous.html crashing http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fhtmlimports%2Fimport-async-previous.html Original issue's description: > Remove ResourceFetcher's access to a real FetchContext at frame detach time > > This allows us to remove a whole bunch of frame() null-checks in FrameFetchContext. > > BUG=458222 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192380 TBR=mkwst@chromium.org,sigbjornf@opera.com,joaoe@opera.com,japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458222 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192454

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+101 lines, -64 lines)
M Source/core/dom/Document.cpp View 4 chunks +11 lines, -16 lines 0 comments
M Source/core/fetch/FetchContext.h View 1 chunk +4 lines, -3 lines 0 comments
M Source/core/fetch/FetchContext.cpp View 1 chunk +0 lines, -6 lines 0 comments
M Source/core/fetch/ImageResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/fetch/ResourceFetcher.h View 1 chunk +1 line, -2 lines 0 comments
M Source/core/fetch/ResourceFetcherTest.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/loader/DocumentLoader.cpp View 2 chunks +1 line, -1 line 0 comments
M Source/core/loader/FrameFetchContext.h View 1 chunk +3 lines, -8 lines 0 comments
M Source/core/loader/FrameFetchContext.cpp View 22 chunks +73 lines, -20 lines 0 comments
M Source/core/loader/FrameFetchContextTest.cpp View 4 chunks +6 lines, -6 lines 0 comments

Messages

Total messages: 3 (0 generated)
alph
Created Revert of Remove ResourceFetcher's access to a real FetchContext at frame detach time
5 years, 9 months ago (2015-03-24 17:25:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012633004/1
5 years, 9 months ago (2015-03-24 17:26:09 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 17:26:47 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192454

Powered by Google App Engine