Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Issue 1012593004: Repeatedly overapproximate the weak closure as long as we make progress (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Repeatedly overapproximate the weak closure as long as we make progress Also, include the time for building object groups in the tracing scope for the overapproximation. BUG=v8:3862 R=hpayer@chromium.org LOG=n Committed: https://crrev.com/82fe1adfed1d458a6a6bbeba47b24438f4512acf Cr-Commit-Position: refs/heads/master@{#27218}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M src/flag-definitions.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/incremental-marking.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 4 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-16 09:57:24 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/1012593004/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/1012593004/diff/1/src/heap/incremental-marking.cc#newcode548 src/heap/incremental-marking.cc:548: void IncrementalMarking::MarkObjectGroups() { Should we have an upper bound ...
5 years, 9 months ago (2015-03-16 12:09:25 UTC) #2
jochen (gone - plz use gerrit)
ptal
5 years, 9 months ago (2015-03-16 12:17:27 UTC) #3
Hannes Payer (out of office)
yey, more flags :) LGTM
5 years, 9 months ago (2015-03-16 12:19:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012593004/20001
5 years, 9 months ago (2015-03-16 12:20:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 12:51:51 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 12:52:04 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82fe1adfed1d458a6a6bbeba47b24438f4512acf
Cr-Commit-Position: refs/heads/master@{#27218}

Powered by Google App Engine
This is Rietveld 408576698