ChromeOS implies Linux

ChromeOS implies Linux

(OS=="linux" or chromeos==1) can be folded into just a
simple *OS=="linux") test because chromeos builds assume
that OS is always set to linux.

Committed: https://crrev.com/810079fac67ffb02451cdf3c776011aa373b2fd4
Cr-Commit-Position: refs/heads/master@{#338239}

[lgombos, 2015-04-02 04:37:00]

l.gombos@samsung.com changed reviewers:
+ dpranke@chromium.org

[lgombos, 2015-04-02 04:37:01]

I belie we should avoid testing specifically for chromeos when we could test for
OS being Linux instead.

Dirk, what do you think ?

[Dirk Pranke, 2015-04-02 18:57:56]

dpranke@chromium.org changed reviewers:
+ thakis@chromium.org

[Dirk Pranke, 2015-04-02 18:57:56]

I think this is probably safe, but I'd like a second opinion in case I'm
forgetting something.

Nico?

-- Dirk

[lgombos, 2015-06-06 01:00:24]

Nico, can you please take a look ?

[Dirk Pranke, 2015-06-06 01:52:40]

I feel comfortable now saying that this is safe :).

lgtm.

[Nico, 2015-06-06 08:01:26]

lgtm

https://codereview.chromium.org/1012483004/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1012483004/diff/20001/build/common.gypi#newco...
build/common.gypi:211: # Enable HiDPI on Mac OS, Windows and Linux.
nit: I'd leave the old comment

[Nico, 2015-06-06 08:02:13]

(having said that, the previous version is kind of more explicit and I'm
not sure the new or the old way is better. I generally tend to not land
patches that mostly look like sidewards movement.)

On Sat, Jun 6, 2015 at 1:01 AM, <thakis@chromium.org> wrote:

> lgtm
>
>
> https://codereview.chromium.org/1012483004/diff/20001/build/common.gypi
> File build/common.gypi (right):
>
>
>
https://codereview.chromium.org/1012483004/diff/20001/build/common.gypi#newco...
> build/common.gypi:211: # Enable HiDPI on Mac OS, Windows and Linux.
> nit: I'd leave the old comment
>
> https://codereview.chromium.org/1012483004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[lgombos, 2015-07-10 03:05:33]

On 2015/06/06 08:02:13, Nico wrote:

Thanks for the reviews.

> (having said that, the previous version is kind of more explicit and I'm
> not sure the new or the old way is better. 

Most places in the code does not list Chrome OS explicitly, so when I see 
Chrome OS explicitly mentioned together with Linux I start wondering 
why that is (in this specific case the reason is that initially the feature 
was only enabled for Chrome OS and later to all Linux environment.

Inconsistencies can (but not always) lead to bugs. In this case there was no
bug.

> I generally tend to not land
> patches that mostly look like sidewards movement.)

Fair point. I'd like to land this one and later maybe combine changes like this
together with bigger changes.

[lgombos, 2015-07-10 03:06:40]

The CQ bit was checked by l.gombos@samsung.com

[lgombos, 2015-07-10 03:06:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1012483004/#ps40001
(title: "Fix nits")

[commit-bot: I haz the power, 2015-07-10 03:06:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1012483004/40001

[commit-bot: I haz the power, 2015-07-10 04:27:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-10 04:28:22]

Patchset 3 (id:??) landed as
https://crrev.com/810079fac67ffb02451cdf3c776011aa373b2fd4
Cr-Commit-Position: refs/heads/master@{#338239}