Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1012483003: SkPDF fix object counting error (Closed)

Created:
5 years, 9 months ago by hal.canary
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/doc/SkDocument_PDF.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
hal canary at chromium
lgtm
5 years, 9 months ago (2015-03-26 20:12:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012483003/1
5 years, 9 months ago (2015-03-26 20:13:13 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-26 20:13:14 UTC) #5
mtklein
How'd you catch this? Is it possible to write a regression test?
5 years, 9 months ago (2015-03-26 20:17:06 UTC) #7
hal.canary
On 2015/03/26 20:17:06, mtklein wrote: > How'd you catch this? Is it possible to write ...
5 years, 9 months ago (2015-03-26 21:01:18 UTC) #8
mtklein
sgtm / lgtm
5 years, 9 months ago (2015-03-26 22:34:00 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 22:35:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/41f88f0251cf48eb06f3f8d143aac8562a230889

Powered by Google App Engine
This is Rietveld 408576698