Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: tools/telemetry/telemetry/page/record_wpr.py

Issue 1012483002: Remove action_name_to_run field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | tools/telemetry/telemetry/page/record_wpr_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/record_wpr.py
diff --git a/tools/telemetry/telemetry/page/record_wpr.py b/tools/telemetry/telemetry/page/record_wpr.py
index 12f4420502a9e8814420e04ab94731ca1f9e1bf1..39b90749ad7502fe3185918f8b6d62b3a41acff0 100644
--- a/tools/telemetry/telemetry/page/record_wpr.py
+++ b/tools/telemetry/telemetry/page/record_wpr.py
@@ -16,11 +16,6 @@ from telemetry.page import test_expectations
from telemetry.results import results_options
from telemetry.user_story import user_story_runner
-_ACTION_NAMES = [
- 'RunPageInteractions',
- 'RunNavigateSteps',
-]
-
class RecorderPageTest(page_test.PageTest): # pylint: disable=W0223
def __init__(self):
super(RecorderPageTest, self).__init__()
@@ -65,22 +60,10 @@ class RecorderPageTest(page_test.PageTest): # pylint: disable=W0223
util.WaitFor(tab.HasReachedQuiescence, 30)
if self.page_test:
- self._action_name_to_run = self.page_test.action_name_to_run
self.page_test.RunPage(page, tab, results)
return
- should_reload = False
- # Run the actions on the page for all available measurements.
- for action_name in _ACTION_NAMES:
- # Skip this action if it is not defined
- if not hasattr(page, action_name):
- continue
- # Reload the page between actions to start with a clean slate.
- if should_reload:
- self.RunNavigateSteps(page, tab)
- self._action_name_to_run = action_name
- super(RecorderPageTest, self).RunPage(page, tab, results)
- should_reload = True
+ super(RecorderPageTest, self).RunPage(page, tab, results)
def RunNavigateSteps(self, page, tab):
if self.page_test:
« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | tools/telemetry/telemetry/page/record_wpr_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698