Issue 1012463003: Make Sky's drawer match Material Design spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1012463003: Make Sky's drawer match Material Design spec (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make Sky's drawer match Material Design spec This CL makes the drawer the correct size and use the correct animation curve. Also, remove the hard-coded z-index values now that hit testing works again. This CL adjusts the mask's opacity to match the drawer in Gmail. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/390c42d41c1759d412ffca09e24dbc8692d98f49

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -8 lines)			Patch
M	sky/framework/animation/curves.dart	View		2 chunks	+18 lines, -0 lines	0 comments	Download
M	sky/framework/components/drawer.dart	View	1	4 chunks	+4 lines, -6 lines	0 comments	Download
M	sky/framework/components/floating_action_button.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/framework/components/toolbar.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-03-16 17:16:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
390c42d41c1759d412ffca09e24dbc8692d98f49 (presubmit successful).