Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1012463002: Revert of Revert of PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS (Closed)

Created:
5 years, 9 months ago by JF
Modified:
5 years, 9 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com, JF, Jim Stichnoth
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Revert of Revert of PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS (patchset #1 id:1 of https://codereview.chromium.org/1002423002/) Reason for revert: I can't repro the failures locally... Flake? Original issue's description: > Revert of PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS (patchset #1 id:1 of https://codereview.chromium.org/1008693005/) > > Reason for revert: > This causes a bunch of failures on the PNaCl toolchain waterfall, which seem related to reading bad data from the stack. Reverting. > > Original issue's description: > > PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > > > > This pulls in the following LLVM changes: > > > > 899d5ab: (stichnot@chromium.org) Allow the LLVM cmake build to use ccache. > > c5f8056: (jfb@chromium.org) ExpandVarArgs: don't pack the vararg struct > > > > BUG= https://code.google.com/p/nativeclient/issues/detail?id=4102 > > TEST= PNaCl toolchain trybots > > TBR= dschuff@chromium.org > > > > Committed: https://chromium.googlesource.com/native_client/src/native_client/+/84b4c32e4b53a143a8599d26df25a4d5d996c825 > > TBR=dschuff@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= https://code.google.com/p/nativeclient/issues/detail?id=4102 > > Committed: https://chromium.googlesource.com/native_client/src/native_client/+/92ab4d5b322a5b8a69ee8fdf3814fdabd25829e5 TBR=dschuff@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= https://code.google.com/p/nativeclient/issues/detail?id=4102 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/8f963fb12e0f3bf3ce4f7d1fd62ae63cf8d408fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pnacl/COMPONENT_REVISIONS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
JF
Created Revert of Revert of PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
5 years, 9 months ago (2015-03-14 18:07:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012463002/1
5 years, 9 months ago (2015-03-14 18:07:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/native_client/src/native_client/+/8f963fb12e0f3bf3ce4f7d1fd62ae63cf8d408fc
5 years, 9 months ago (2015-03-14 18:07:37 UTC) #3
JF
5 years, 9 months ago (2015-03-14 20:58:01 UTC) #4
Message was sent while issue was closed.
FWIW I figured out the problem after unfailing to repro. Pretty silly, I'll send
a fix.

Powered by Google App Engine
This is Rietveld 408576698