Autofill: Recognize month/year selects when searching for credit cards.

Autofill: Recognize month/year selects when searching for credit cards.

Also add ccv as yet another abbreviation for the card security code.

BUG=428892, 464028, 466685
Committed: https://crrev.com/0067981c3a2527b16cf1b35c2830102dcdcdb530
Cr-Commit-Position: refs/heads/master@{#321469}

[Lei Zhang, 2015-03-18 02:35:10]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2015-03-18 02:38:41]

Patchset #1 (id:20001) has been deleted

[Lei Zhang, 2015-03-18 02:38:50]

thestig@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2015-03-18 04:29:26]

https://codereview.chromium.org/1012363002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/credit_card_field.cc (right):

https://codereview.chromium.org/1012363002/diff/40001/components/autofill/cor...
components/autofill/core/browser/credit_card_field.cc:39: while
(regex_needles.size() <= haystack_remaining_size) {
for (size_t i = 0; i < haystack.size() - regex_needles.size() + 1; ++i)

https://codereview.chromium.org/1012363002/diff/40001/components/autofill/cor...
components/autofill/core/browser/credit_card_field.cc:253: if
(FindConsecutiveStrings(years_to_check, field->option_values))
if X
  return true
return Y

is equivalent to

return X || Y

[Lei Zhang, 2015-03-18 18:04:49]

Patchset #2 (id:60001) has been deleted

[Lei Zhang, 2015-03-18 18:08:56]

https://codereview.chromium.org/1012363002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/credit_card_field.cc (right):

https://codereview.chromium.org/1012363002/diff/40001/components/autofill/cor...
components/autofill/core/browser/credit_card_field.cc:39: while
(regex_needles.size() <= haystack_remaining_size) {
On 2015/03/18 04:29:25, Evan Stade wrote:
> for (size_t i = 0; i < haystack.size() - regex_needles.size() + 1; ++i)

Done.

https://codereview.chromium.org/1012363002/diff/40001/components/autofill/cor...
components/autofill/core/browser/credit_card_field.cc:253: if
(FindConsecutiveStrings(years_to_check, field->option_values))
On 2015/03/18 04:29:25, Evan Stade wrote:
> if X
>   return true
> return Y
> 
> is equivalent to
> 
> return X || Y

Done.

[Evan Stade, 2015-03-18 20:41:24]

https://codereview.chromium.org/1012363002/diff/80001/components/autofill/cor...
File components/autofill/core/browser/credit_card_field.cc (right):

https://codereview.chromium.org/1012363002/diff/80001/components/autofill/cor...
components/autofill/core/browser/credit_card_field.cc:40: for (const
base::string16& regex : regex_needles) {
for (int j = 0; j < regex_needles.size(); ++j) {
  if (!MatchesPattern(haystack[i + j], regex_needles[j]))
    break;

  if (j == regex_needles.size() - 1)
    return true;
}

(the reason I'm picking these nits is that I think declaring and incrementing
iterators in non-standard places is much harder to read than a typical for loop)

[Lei Zhang, 2015-03-19 02:33:28]

https://codereview.chromium.org/1012363002/diff/80001/components/autofill/cor...
File components/autofill/core/browser/credit_card_field.cc (right):

https://codereview.chromium.org/1012363002/diff/80001/components/autofill/cor...
components/autofill/core/browser/credit_card_field.cc:40: for (const
base::string16& regex : regex_needles) {
On 2015/03/18 20:41:24, Evan Stade wrote:
> for (int j = 0; j < regex_needles.size(); ++j) {
>   if (!MatchesPattern(haystack[i + j], regex_needles[j]))
>     break;
> 
>   if (j == regex_needles.size() - 1)
>     return true;
> }
> 
> (the reason I'm picking these nits is that I think declaring and incrementing
> iterators in non-standard places is much harder to read than a typical for
loop)

Done.

[Evan Stade, 2015-03-19 15:56:39]

lgtm

https://codereview.chromium.org/1012363002/diff/100001/components/autofill/co...
File components/autofill/core/browser/credit_card_field.cc (right):

https://codereview.chromium.org/1012363002/diff/100001/components/autofill/co...
components/autofill/core/browser/credit_card_field.cc:313: if
(LikelyCardYearSelectField(scanner)) {
I wonder if some locales do year then month?

[Lei Zhang, 2015-03-19 18:32:51]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-03-19 18:32:54]

The CQ bit was unchecked by thestig@chromium.org

[Lei Zhang, 2015-03-19 18:35:57]

https://codereview.chromium.org/1012363002/diff/100001/components/autofill/co...
File components/autofill/core/browser/credit_card_field.cc (right):

https://codereview.chromium.org/1012363002/diff/100001/components/autofill/co...
components/autofill/core/browser/credit_card_field.cc:313: if
(LikelyCardYearSelectField(scanner)) {
On 2015/03/19 15:56:39, Evan Stade wrote:
> I wonder if some locales do year then month?

Probably, but everything below assumes month/year as well.

[Lei Zhang, 2015-03-19 18:36:02]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-03-19 18:36:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1012363002/100001

[commit-bot: I haz the power, 2015-03-19 20:02:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-19 20:02:48]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2015-03-19 21:41:59]

https://codereview.chromium.org/1012363002/diff/120001/components/autofill/co...
File components/autofill/core/browser/credit_card_field.cc (right):

https://codereview.chromium.org/1012363002/diff/120001/components/autofill/co...
components/autofill/core/browser/credit_card_field.cc:37: for (size_t i = 0; i <
haystack.size() - regex_needles.size() + 1; ++i) {
Test failed because the subtraction underflowed and we went out of bounds.

[Lei Zhang, 2015-03-19 21:42:03]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-03-19 21:42:03]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1012363002/#ps140001
(title: "fix out of bounds indexing")

[commit-bot: I haz the power, 2015-03-19 21:43:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1012363002/140001

[commit-bot: I haz the power, 2015-03-19 23:39:42]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2015-03-19 23:40:17]

Patchset 5 (id:??) landed as
https://crrev.com/0067981c3a2527b16cf1b35c2830102dcdcdb530
Cr-Commit-Position: refs/heads/master@{#321469}