Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1012333004: HSTS preload submissions as of 2015-03-19. (Closed)

Created:
5 years, 9 months ago by lgarron
Modified:
5 years, 9 months ago
Reviewers:
agl
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HSTS preload submissions as of 2015-03-19. BUG= Committed: https://crrev.com/3fcd7d8496804a6f9225dd7937f65ea0bc457a04 Cr-Commit-Position: refs/heads/master@{#321528}

Patch Set 1 #

Patch Set 2 : Include the updated .h file. #

Patch Set 3 : Remove site using a SHA-1 cert expiring after 2015. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1656 lines, -1538 lines) Patch
M net/http/transport_security_state_static.h View 1 2 3 1 chunk +1588 lines, -1537 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 2 3 1 chunk +68 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
lgarron
I allowed SHA-1 certs, as usual. Given the active deprecation timeline, should we consider starting ...
5 years, 9 months ago (2015-03-19 22:22:13 UTC) #2
agl
LGTM. I allow SHA-1 that expires within 2015. I'm rejecting >= 2016 (including for the ...
5 years, 9 months ago (2015-03-19 22:36:11 UTC) #3
lgarron
On 2015/03/19 at 22:36:11, agl wrote: > LGTM. > > I allow SHA-1 that expires ...
5 years, 9 months ago (2015-03-19 22:47:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012333004/40001
5 years, 9 months ago (2015-03-19 22:48:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/58374)
5 years, 9 months ago (2015-03-19 23:10:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012333004/60001
5 years, 9 months ago (2015-03-20 05:58:38 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-20 06:55:52 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 06:56:23 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3fcd7d8496804a6f9225dd7937f65ea0bc457a04
Cr-Commit-Position: refs/heads/master@{#321528}

Powered by Google App Engine
This is Rietveld 408576698