Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: runtime/vm/service_test.cc

Issue 1012333002: Keep zone cached in SnapshotReader to allow removing ZoneHandle(Isolate*) interface. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/service_isolate.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 6
7 #include "include/dart_debugger_api.h" 7 #include "include/dart_debugger_api.h"
8 #include "vm/dart_api_impl.h" 8 #include "vm/dart_api_impl.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/debugger.h" 10 #include "vm/debugger.h"
(...skipping 17 matching lines...) Expand all
28 ~ServiceTestMessageHandler() { 28 ~ServiceTestMessageHandler() {
29 free(_msg); 29 free(_msg);
30 } 30 }
31 31
32 bool HandleMessage(Message* message) { 32 bool HandleMessage(Message* message) {
33 if (_msg != NULL) { 33 if (_msg != NULL) {
34 free(_msg); 34 free(_msg);
35 } 35 }
36 36
37 // Parse the message. 37 // Parse the message.
38 SnapshotReader reader(message->data(), message->len(), 38 SnapshotReader reader(message->data(), message->len(), Snapshot::kMessage,
39 Snapshot::kMessage, Isolate::Current()); 39 Isolate::Current(), Thread::Current()->zone());
40 const Object& response_obj = Object::Handle(reader.ReadObject()); 40 const Object& response_obj = Object::Handle(reader.ReadObject());
41 String& response = String::Handle(); 41 String& response = String::Handle();
42 response ^= response_obj.raw(); 42 response ^= response_obj.raw();
43 _msg = strdup(response.ToCString()); 43 _msg = strdup(response.ToCString());
44 return true; 44 return true;
45 } 45 }
46 46
47 // Removes a given json key:value from _msg. 47 // Removes a given json key:value from _msg.
48 void filterMsg(const char* key) { 48 void filterMsg(const char* key) {
49 int key_len = strlen(key); 49 int key_len = strlen(key);
(...skipping 1422 matching lines...) Expand 10 before | Expand all | Expand 10 after
1472 Eval(lib, "[0, port, 'getCpuProfile', ['tags'], ['Bogus']]"); 1472 Eval(lib, "[0, port, 'getCpuProfile', ['tags'], ['Bogus']]");
1473 Service::HandleIsolateMessage(isolate, service_msg); 1473 Service::HandleIsolateMessage(isolate, service_msg);
1474 handler.HandleNextMessage(); 1474 handler.HandleNextMessage();
1475 // Expect error. 1475 // Expect error.
1476 EXPECT_SUBSTRING("\"type\":\"Error\"", handler.msg()); 1476 EXPECT_SUBSTRING("\"type\":\"Error\"", handler.msg());
1477 } 1477 }
1478 1478
1479 #endif // !defined(TARGET_ARCH_ARM64) 1479 #endif // !defined(TARGET_ARCH_ARM64)
1480 1480
1481 } // namespace dart 1481 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/service_isolate.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698