Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 101223013: win msvs: make express editions not use x64-x64 compiler (Closed)

Created:
6 years, 11 months ago by davids
Modified:
6 years, 11 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

win msvs: make express editions not use x64-x64 compiler VS2012 express and others do not include a 64 bit compiler that generates 64 bit code. This patch makes it so the 64 bit compiler is only enabled when not using a Visual Studio express edition. Patch from david@sankelsoftware.com. R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M pylib/gyp/MSVSVersion.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
davids
This is another review request for the "win msvs: make express..." issue that hopefully was ...
6 years, 11 months ago (2014-01-07 03:42:05 UTC) #1
scottmg
thanks, lgtm. I'll land it for you.
6 years, 11 months ago (2014-01-07 04:45:35 UTC) #2
scottmg
6 years, 11 months ago (2014-01-07 04:52:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1829 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698