Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 101223009: GTTF: Make new test launcher automatically use single process mode when debugged. (Closed)

Created:
7 years ago by Paweł Hajdan Jr.
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

GTTF: Make new test launcher automatically use single process mode when debugged. This also applies on Valgrind. Use --test-launcher-debug-launcher to override auto-detection and debug the launcher itself. BUG=236893 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240186

Patch Set 1 #

Patch Set 2 : android #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M base/test/launcher/unit_test_launcher.cc View 1 4 chunks +34 lines, -1 line 0 comments Download
M base/test/test_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/test_switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years ago (2013-12-11 02:09:33 UTC) #1
sky
Nice, LGTM
7 years ago (2013-12-11 14:57:41 UTC) #2
Paweł Hajdan Jr.
7 years ago (2013-12-11 21:53:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r240186 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698